From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: [PATCH 07/11] Fix crash after firmware flash when IO is running.
Date: Thu, 15 Jun 2017 22:56:47 -0700 [thread overview]
Message-ID: <20170616055651.9674-8-jsmart2021@gmail.com> (raw)
In-Reply-To: <20170616055651.9674-1-jsmart2021@gmail.com>
OS crashes after the completion of firmware download.
Failure in posting SCSI SGL buffers because number of SGL buffers
is less than total count. Some of the pending IOs are not completed
by driver. SGL buffers for these IOs are not added back to the list.
Pending IOs are not completed because lpfc_wq_list list is
initialized before completion of pending IOs.
Postpone lpfc_wq_list reinitialization by moving
lpfc_sli4_queue_destroy() after lpfc_hba_down_post().
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 4f2cc395597e..8de70b9d79dd 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -4303,7 +4303,6 @@ lpfc_sli4_brdreset(struct lpfc_hba *phba)
/* Perform FCoE PCI function reset before freeing queue memory */
rc = lpfc_pci_function_reset(phba);
- lpfc_sli4_queue_destroy(phba);
/* Restore PCI cmd register */
pci_write_config_word(phba->pcidev, PCI_COMMAND, cfg_value);
@@ -4428,6 +4427,7 @@ lpfc_sli_brdrestart_s4(struct lpfc_hba *phba)
pci_disable_pcie_error_reporting(phba->pcidev);
lpfc_hba_down_post(phba);
+ lpfc_sli4_queue_destroy(phba);
return rc;
}
--
2.11.0
next prev parent reply other threads:[~2017-06-16 5:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 5:56 [PATCH 00/11] lpfc updates for 11.4.0.1 James Smart
2017-06-16 5:56 ` [PATCH 01/11] Fix system panic when express lane enabled James Smart
2017-06-16 7:50 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 02/11] Fix nvme_info sysfs output to be consistent James Smart
2017-06-16 7:51 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 03/11] Vport creation is failing with "Link Down" error James Smart
2017-06-16 7:51 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 04/11] Reduce time spent in IRQ for received NVME commands James Smart
2017-06-16 7:52 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 05/11] Break up IO ctx list into a separate get and put list James Smart
2017-06-16 7:59 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 06/11] Fix SLI3 drivers attempting NVME ELS commands James Smart
2017-06-16 8:00 ` Hannes Reinecke
2017-06-16 5:56 ` James Smart [this message]
2017-06-16 8:01 ` [PATCH 07/11] Fix crash after firmware flash when IO is running Hannes Reinecke
2017-06-16 5:56 ` [PATCH 08/11] Fix crash doing IO with resets James Smart
2017-06-16 8:02 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 09/11] Fix crash in lpfc_sli_ringtxcmpl_put when nvmet gets an abort request James Smart
2017-06-16 8:02 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 10/11] Driver responds LS_RJT to Beacon Off ELS - Linux James Smart
2017-06-16 8:03 ` Hannes Reinecke
2017-06-16 5:56 ` [PATCH 11/11] lpfc: update to revision to 11.4.0.1 James Smart
2017-06-16 8:03 ` Hannes Reinecke
2017-06-20 1:42 ` [PATCH 00/11] lpfc updates for 11.4.0.1 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616055651.9674-8-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).