From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling Date: Mon, 19 Jun 2017 10:09:11 +0200 Message-ID: <20170619080910.GA3752@linux-x5ow.site> References: <20170616224744.3681-1-himanshu.madhani@cavium.com> <20170616224744.3681-2-himanshu.madhani@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:44085 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751166AbdFSIJQ (ORCPT ); Mon, 19 Jun 2017 04:09:16 -0400 Content-Disposition: inline In-Reply-To: <20170616224744.3681-2-himanshu.madhani@cavium.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Himanshu Madhani Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, giridhar.malaval@cavium.com, darren.trapp@cavium.com On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote: > From: Duane Grigsby > > Signed-off-by: Darren Trapp > Signed-off-by: Duane Grigsby > Signed-off-by: Anil Gurumurthy > Signed-off-by: Giridhar Malavali > Signed-off-by: Himanshu Madhani > --- [...] > + > + if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) || > + (fcport->fw_login_state == DSC_LS_PLOGI_COMP) || > + (fcport->fw_login_state == DSC_LS_PRLI_PEND)) > + return rval; Minor nit, superfluous parenthesis. Anyways, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850