[PATCH] lpfc: fix refcount error on node list

[PATCH] lpfc: fix refcount error on node list

[James Smart]

A change in remote port removal introduced a spurious put which
can cause a premature structure teardown. The affects were most
notable when the driver attempted to unload as a null pointer
would be hit.

Fix by removing the unnecessary put.

Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_init.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 7e73fdc154f7..491aa95eb0f6 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -2805,13 +2805,6 @@ lpfc_cleanup(struct lpfc_vport *vport)
 			lpfc_disc_state_machine(vport, ndlp, NULL,
 					NLP_EVT_DEVICE_RECOVERY);
 
-		if (ndlp->nlp_fc4_type & NLP_FC4_NVME) {
-			/* Remove the NVME transport reference now and
-			 * continue to remove the node.
-			 */
-			lpfc_nlp_put(ndlp);
-		}
-
 		lpfc_disc_state_machine(vport, ndlp, NULL,
 					     NLP_EVT_DEVICE_RM);
 	}
-- 
2.11.0

Re: [PATCH] lpfc: fix refcount error on node list

[Johannes Thumshirn]

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] lpfc: fix refcount error on node list

[Martin K. Petersen]

James,

> A change in remote port removal introduced a spurious put which can
> cause a premature structure teardown. The affects were most notable
> when the driver attempted to unload as a null pointer would be hit.
>
> Fix by removing the unnecessary put.

Applied to 4.13/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering