Re: [PATCH 19/28] qedf: drop bus reset handler

Chad Dupuis
2017-06-28T14:08:09Z

On Wed, 28 Jun 2017, 9:58am, Christoph Hellwig wrote:

> On Wed, Jun 28, 2017 at 10:25:07AM +0200, Hannes Reinecke wrote:
> > qedf has a host reset handler, but as the bus reset handler is
> > a stub always returning SUCCESS the host reset is never invoked.
> > So drop the bus reset handler.
>
> Given that comment this needs a lot more explanation, as the current
> behavior seems to be an odd/buggy workaround.
>
> I hope this patch won't block the rest of the series, which all seems
> nice and simple material for this late merge window :(
>

The test case this was meant to fix as using the sg_reset utility with the
-b option which forces a bus reset with NPIV ports attached. What we were
finding is that some of the devices attached to the vport were being
brought offline after 5 seconds as escalating to the host reset handler in
this case was taking too long.

For this specific test case, returning SUCCESS allowed us to bypass the
host reset escalation and force the SCSI error handler to send a TUR to
the devices which of course would succeed since the device weren't
physically offline keeping them from going offline.