Re: [PATCH 01/28] scsi: fix comment in scsi_device_set_state()

Christoph Hellwig
2017-06-28T13:54:59Z

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

On Wed, Jun 28, 2017 at 10:24:49AM +0200, Hannes Reinecke wrote:
> The function returns '0' if successful; with the original comment
> the function doesn't have a way to indicate success ...
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Bart van Assche <bvanassche@wdc.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 41c19c7..1ff7d72 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -2547,7 +2547,7 @@ void scsi_exit_queue(void)
> * @sdev: scsi device to change the state of.
> * @state: state to change to.
> *
> - * Returns zero if unsuccessful or an error if the requested
> + * Returns zero if successful or an error if the requested
> * transition is illegal.
> */
> int
> --
> 1.8.5.6
---end quoted text---