RE: [PATCH 05/47] aacraid: enable sending of TMFs from aac_hba_send()

Raghava Aditya Renukunta
2017-06-29T20:07:24Z

> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of Hannes Reinecke
> Sent: Wednesday, June 28, 2017 1:33 AM
> To: Christoph Hellwig <hch@lst.de>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>; James Bottomley
> <james.bottomley@hansenpartnership.com>; linux-scsi@vger.kernel.org;
> Hannes Reinecke <hare@suse.de>; Hannes Reinecke <hare@suse.com>
> Subject: [PATCH 05/47] aacraid: enable sending of TMFs from
> aac_hba_send()
>
> EXTERNAL EMAIL
>
>
> aac_hba_send() will return FAILED for any non-SCSI command requests,
> failing any TMFs. This patch updates the check to allow TMFs.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/scsi/aacraid/commsup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
> index 1c617cc..348f0ea 100644
> --- a/drivers/scsi/aacraid/commsup.c
> +++ b/drivers/scsi/aacraid/commsup.c
> @@ -770,7 +770,7 @@ int aac_hba_send(u8 command, struct fib *fibptr,
> fib_callback callback,
> /* bit1 of request_id must be 0 */
> hbacmd->request_id =
> cpu_to_le32((((u32)(fibptr - dev->fibs)) << 2) + 1);
> - } else
> + } else if (command != HBA_IU_TYPE_SCSI_TM_REQ)
> return -EINVAL;
>
>
> --
> 1.8.5.6

Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@microsemi.com>