Re: [PATCH 09/47] zfcp: open-code fc_block_scsi_eh() for host reset

Steffen Maier
2017-07-24T16:24:21Z

On 06/28/2017 10:32 AM, Hannes Reinecke wrote:
> When issuing a host reset we should be waiting for all
> ports to become unblocked; just waiting for one might
> be resulting in host reset to return too early.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/s390/scsi/zfcp_scsi.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c
> index 0678cf7..3d18659 100644
> --- a/drivers/s390/scsi/zfcp_scsi.c
> +++ b/drivers/s390/scsi/zfcp_scsi.c
> @@ -311,13 +311,32 @@ static int zfcp_scsi_eh_target_reset_handler(struct scsi_cmnd *scpnt)
>
> static int zfcp_scsi_eh_host_reset_handler(struct scsi_cmnd *scpnt)
> {
> - struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(scpnt->device);
> - struct zfcp_adapter *adapter = zfcp_sdev->port->adapter;
> - int ret;
> + struct Scsi_Host *host = scpnt->device->host;
> + struct zfcp_adapter *adapter = (struct zfcp_adapter *)host->hostdata[0];

Oh, only realized when reading the later "[PATCH 14/47] scsi: Use
Scsi_Host as argument for eh_host_reset_handler" that this part already
anticipates parts of that later patch. Seems not fully topically
separated patches to me, if this one is only about the fc_block_scsi_eh
aspect in zfcp_scsi_eh_host_reset_handler().

--
Mit freundlichen Grüßen / Kind regards
Steffen Maier

Linux on z Systems Development

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294