Re: [PATCH 04/47] aacraid: use aac_tmf_callback for reset fib

Hannes Reinecke
2017-06-30T07:19:19Z

On 06/29/2017 10:06 PM, Raghava Aditya Renukunta wrote:
> [.....]
>> @@ -879,8 +906,12 @@ static int aac_eh_dev_reset(struct scsi_cmnd *cmd)
> [......]
>> bus = aac_logical_to_phys(scmd_channel(cmd));
>> cid = scmd_id(cmd);
>> + info = &aac->hba_map[bus][cid];
>> if (bus >= AAC_MAX_BUSES || cid >= AAC_MAX_TARGETS ||
>> - aac->hba_map[bus][cid].devtype != AAC_DEVTYPE_NATIVE_RAW)
>> + info->devtype != AAC_DEVTYPE_NATIVE_RAW)
>> + return FAILED;
>> +
>> + if (info->reset_state > 0)
>> return FAILED;
> [......]
>
>> @@ -932,8 +962,9 @@ static int aac_eh_target_reset(struct scsi_cmnd
>> *cmd)
>>
>> bus = aac_logical_to_phys(scmd_channel(cmd));
>> cid = scmd_id(cmd);
>> + info = &aac->hba_map[bus][cid];
>> if (bus >= AAC_MAX_BUSES || cid >= AAC_MAX_TARGETS ||
>> - aac->hba_map[bus][cid].devtype != AAC_DEVTYPE_NATIVE_RAW)
>> + info->devtype != AAC_DEVTYPE_NATIVE_RAW)
>> return FAILED;
>
> Can we have a
> If (info->reset_state > 0
> Return FAILED;
> here as well?
>
Sure.

Thanks for the review.

Cheers

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)