From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Chad Dupuis <chad.dupuis@cavium.com>
Subject: Re: [PATCH 19/28] qedf: drop bus reset handler
Date: Wed, 28 Jun 2017 15:58:58 +0200 [thread overview]
Message-ID: <20170628135858.GI1268@lst.de> (raw)
In-Reply-To: <1498638316-44420-20-git-send-email-hare@suse.de>
On Wed, Jun 28, 2017 at 10:25:07AM +0200, Hannes Reinecke wrote:
> qedf has a host reset handler, but as the bus reset handler is
> a stub always returning SUCCESS the host reset is never invoked.
> So drop the bus reset handler.
Given that comment this needs a lot more explanation, as the current
behavior seems to be an odd/buggy workaround.
I hope this patch won't block the rest of the series, which all seems
nice and simple material for this late merge window :(
next prev parent reply other threads:[~2017-06-28 13:58 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 8:24 [PATCH 00/28] SCSI EH argument reshuffle part I Hannes Reinecke
2017-06-28 8:24 ` [PATCH 01/28] scsi: fix comment in scsi_device_set_state() Hannes Reinecke
2017-06-28 8:36 ` Johannes Thumshirn
2017-06-28 13:54 ` Christoph Hellwig
2017-06-28 8:24 ` [PATCH 02/28] mptfc: Do not call fc_block_scsi_eh() on host reset Hannes Reinecke
2017-06-28 8:36 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 03/28] ibmvfc: " Hannes Reinecke
2017-06-28 8:37 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 04/28] fc_fcp: do not call fc_block_scsi_eh() from " Hannes Reinecke
2017-06-28 8:37 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 05/28] fnic: do not call host reset from command abort Hannes Reinecke
2017-06-28 8:38 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 06/28] uas: move eh_bus_reset_handler to eh_device_reset_handler Hannes Reinecke
2017-06-28 8:39 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 07/28] libsas: move bus_reset_handler() to target_reset_handler() Hannes Reinecke
2017-06-28 8:41 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 08/28] bfa: move bus reset to target reset Hannes Reinecke
2017-06-28 8:44 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 09/28] hptiop: Simplify reset handling Hannes Reinecke
2017-06-28 8:45 ` Johannes Thumshirn
2017-06-28 8:24 ` [PATCH 10/28] fdomain: move bus reset to host reset Hannes Reinecke
2017-06-28 8:45 ` Johannes Thumshirn
2017-06-28 13:55 ` Christoph Hellwig
2017-06-28 8:24 ` [PATCH 11/28] scsi: drop bus reset for wd33c93-compatible boards Hannes Reinecke
2017-06-28 8:46 ` Johannes Thumshirn
2017-06-28 13:56 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 12/28] rtsx: drop bus reset function Hannes Reinecke
2017-06-28 8:47 ` Johannes Thumshirn
2017-06-28 8:25 ` [PATCH 13/28] qlogicpti: move bus reset to host reset Hannes Reinecke
2017-06-28 8:54 ` Johannes Thumshirn
2017-06-28 8:25 ` [PATCH 14/28] acornscsi: " Hannes Reinecke
2017-06-28 8:55 ` Johannes Thumshirn
2017-06-28 8:25 ` [PATCH 15/28] NCR5380: Move " Hannes Reinecke
2017-06-28 8:55 ` Johannes Thumshirn
2017-06-28 13:57 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 16/28] qlogicfas: move bus_reset to host_reset Hannes Reinecke
2017-06-28 8:56 ` Johannes Thumshirn
2017-06-28 8:25 ` [PATCH 17/28] imm: drop duplicate bus_reset handler Hannes Reinecke
2017-06-28 8:58 ` Johannes Thumshirn
2017-06-28 13:57 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 18/28] ppa: " Hannes Reinecke
2017-06-28 8:58 ` Johannes Thumshirn
2017-06-28 13:58 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 19/28] qedf: drop bus reset handler Hannes Reinecke
2017-06-28 13:58 ` Christoph Hellwig [this message]
2017-06-28 14:07 ` Chad Dupuis
2017-06-28 14:37 ` Christoph Hellwig
2017-06-28 15:05 ` Chad Dupuis
2017-06-28 8:25 ` [PATCH 20/28] nsp32: drop bus reset Hannes Reinecke
2017-06-28 8:59 ` Johannes Thumshirn
2017-06-28 14:00 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 21/28] aha152x: " Hannes Reinecke
2017-06-28 9:00 ` Johannes Thumshirn
2017-06-28 14:02 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 22/28] 53c700: move bus reset to host reset Hannes Reinecke
2017-06-28 14:05 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 23/28] bnx2fc: remove obsolete bnx2fc_eh_host_reset() definition Hannes Reinecke
2017-06-28 9:01 ` Johannes Thumshirn
2017-06-28 8:25 ` [PATCH 24/28] megaraid_mbox: drop duplicate bus reset and device reset function Hannes Reinecke
2017-06-28 9:01 ` Johannes Thumshirn
2017-06-28 14:05 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 25/28] lpfc: drop lpfc_no_handler and lpfc_bus_reset_handler() Hannes Reinecke
2017-06-28 8:25 ` [PATCH 26/28] visorhba: sanitze private device data allocation Hannes Reinecke
2017-06-30 20:16 ` Kershner, David A
[not found] ` <CY4PR07MB3176109C5BDB7B51AD3BB73FF0A60@CY4PR07MB3176.namprd07.prod.outlook.com>
2017-07-24 9:28 ` Hannes Reinecke
2017-06-28 8:25 ` [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset() Hannes Reinecke
2017-06-28 9:03 ` Johannes Thumshirn
2017-06-28 14:06 ` Christoph Hellwig
2017-06-28 8:25 ` [PATCH 28/28] NCR5380: Clear all unissued commands on host reset Hannes Reinecke
2017-06-28 9:04 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628135858.GI1268@lst.de \
--to=hch@lst.de \
--cc=chad.dupuis@cavium.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox