* [PATCH] virtio_scsi: always read VPD pages for multiqueue too
@ 2017-07-05 8:30 Paolo Bonzini
2017-07-05 8:43 ` Fam Zheng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paolo Bonzini @ 2017-07-05 8:30 UTC (permalink / raw)
To: linux-scsi, linux-kernel
Cc: jejb, martin.petersen, stefanha, famz, stable, David Gibson
Multi-queue virtio-scsi uses a different scsi_host_template struct.
Add the .device_alloc field there, too.
Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
Cc: stable@vger.kernel.org
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
drivers/scsi/virtio_scsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index f8dbfeee6c63..ad1e7f1aba4c 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -826,6 +826,7 @@ static int virtscsi_map_queues(struct Scsi_Host *shost)
.change_queue_depth = virtscsi_change_queue_depth,
.eh_abort_handler = virtscsi_abort,
.eh_device_reset_handler = virtscsi_device_reset,
+ .slave_alloc = virtscsi_device_alloc,
.can_queue = 1024,
.dma_boundary = UINT_MAX,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too
2017-07-05 8:30 [PATCH] virtio_scsi: always read VPD pages for multiqueue too Paolo Bonzini
@ 2017-07-05 8:43 ` Fam Zheng
2017-07-11 12:29 ` Stefan Hajnoczi
2017-07-12 21:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2017-07-05 8:43 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-scsi, linux-kernel, jejb, martin.petersen, stefanha, stable,
David Gibson
On Wed, 07/05 10:30, Paolo Bonzini wrote:
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
>
> Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
> Cc: stable@vger.kernel.org
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> drivers/scsi/virtio_scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index f8dbfeee6c63..ad1e7f1aba4c 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -826,6 +826,7 @@ static int virtscsi_map_queues(struct Scsi_Host *shost)
> .change_queue_depth = virtscsi_change_queue_depth,
> .eh_abort_handler = virtscsi_abort,
> .eh_device_reset_handler = virtscsi_device_reset,
> + .slave_alloc = virtscsi_device_alloc,
>
> .can_queue = 1024,
> .dma_boundary = UINT_MAX,
> --
> 1.8.3.1
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too
2017-07-05 8:30 [PATCH] virtio_scsi: always read VPD pages for multiqueue too Paolo Bonzini
2017-07-05 8:43 ` Fam Zheng
@ 2017-07-11 12:29 ` Stefan Hajnoczi
2017-07-12 21:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-07-11 12:29 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-scsi, linux-kernel, jejb, martin.petersen, famz, stable,
David Gibson
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Wed, Jul 05, 2017 at 10:30:56AM +0200, Paolo Bonzini wrote:
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
>
> Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
> Cc: stable@vger.kernel.org
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> drivers/scsi/virtio_scsi.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtio_scsi: always read VPD pages for multiqueue too
2017-07-05 8:30 [PATCH] virtio_scsi: always read VPD pages for multiqueue too Paolo Bonzini
2017-07-05 8:43 ` Fam Zheng
2017-07-11 12:29 ` Stefan Hajnoczi
@ 2017-07-12 21:16 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2017-07-12 21:16 UTC (permalink / raw)
To: Paolo Bonzini
Cc: linux-scsi, linux-kernel, jejb, martin.petersen, stefanha, famz,
stable, David Gibson
Paolo,
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
Applied to 4.13/scsi-fixes by hand. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-12 21:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-05 8:30 [PATCH] virtio_scsi: always read VPD pages for multiqueue too Paolo Bonzini
2017-07-05 8:43 ` Fam Zheng
2017-07-11 12:29 ` Stefan Hajnoczi
2017-07-12 21:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).