From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: Nero 4 Linux applications broken in 4.12 Date: Wed, 5 Jul 2017 14:42:29 +0200 Message-ID: <20170705124229.GH4076@linux-x5ow.site> References: <460fefb4-d002-6989-0c90-63ea0e209fc3@googlemail.com> <20170705073928.GA4076@linux-x5ow.site> <9c58bac7-ddf4-3e47-b729-76e595804836@googlemail.com> <20170705084447.GD4076@linux-x5ow.site> <20170705084810.GE4076@linux-x5ow.site> <20170705115235.GF4076@linux-x5ow.site> <3790b5ad-c02f-6406-173b-f2a0563f642b@googlemail.com> <20170705120927.GG4076@linux-x5ow.site> <8834e9d2-3018-ee8f-b40e-ccd8aecc367c@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:41847 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751772AbdGEMme (ORCPT ); Wed, 5 Jul 2017 08:42:34 -0400 Content-Disposition: inline In-Reply-To: <8834e9d2-3018-ee8f-b40e-ccd8aecc367c@googlemail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Chris Clayton Cc: linux-scsi@vger.kernel.org On Wed, Jul 05, 2017 at 01:19:09PM +0100, Chris Clayton wrote: > I'm happy to test any patches you may propose. Can you verify this fix? Preferedably with using Nero. It passes my small reproducer: >>From f52502180cc3843f8acc956253af2575245546a8 Mon Sep 17 00:00:00 2001 From: Johannes Thumshirn Date: Wed, 5 Jul 2017 14:31:47 +0200 Subject: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid direction before starting the request") Signed-off-by: Johannes Thumshirn Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the request") --- drivers/scsi/sg.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 21225d62b0c1..3c91593260aa 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -758,8 +758,11 @@ static bool sg_is_valid_dxfer(sg_io_hdr_t *hp) if (hp->dxferp || hp->dxfer_len > 0) return false; return true; - case SG_DXFER_TO_DEV: case SG_DXFER_FROM_DEV: + if (hp->dxferp || hp->dxfer_len < 0) + return false; + return true; + case SG_DXFER_TO_DEV: case SG_DXFER_TO_FROM_DEV: if (!hp->dxferp || hp->dxfer_len == 0) return false; -- 2.12.3 -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850