public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Meelis Roos <mroos@linux.ee>
Cc: Don Brace <don.brace@microsemi.com>,
	Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	Jens Axboe <axboe@kernel.dk>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] hpsa: add support for legacy boards
Date: Wed, 12 Jul 2017 09:11:21 +0200	[thread overview]
Message-ID: <20170712071121.GA5545@lst.de> (raw)
In-Reply-To: <alpine.LRH.2.20.1707111853330.9598@math.ut.ee>

On Tue, Jul 11, 2017 at 06:58:36PM +0300, Meelis Roos wrote:
> > The 5i controller is probably too old for the hpsa driver to support. 
> > The hpsa driver is looking for information to determine if the drive is online/offline and
> > this information is not available.
> > 
> > What was the original issue you were having with the cciss driver?
> 
> Christoph Hellwig updated block layer with "block: Make most 
> scsi_req_init() calls implicit" and at first try, cciss was left without 
> the needed initialization. This caused OOPS in udev probing but the 
> system worked. The issue was fixed by Christoph quickly.

The original patch is from Bart, but otherwise correct.

> But he suggested it might be worth trying hpsa driver instead of cciss, 
> with a longer term goal to to move users of cciss over to hpsa if 
> possible. Now that I have tested it, it seems not all older cards are 
> supported in hpsa - it's more than ID-s and interrupt masks.

Seems like it.  And the idea behind this game is that we'd like to slowly
get rid of old request_fn based drivers.  Given that hpsa supports very
similar hardware cciss is a target for removal once that hardware is
switched over.  But it seems like we'll need more work in this area..

> 
> -- 
> Meelis Roos (mroos@linux.ee)
---end quoted text---

  reply	other threads:[~2017-07-12  7:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  6:49 [PATCH] hpsa: add support for legacy boards Hannes Reinecke
2017-07-11 14:25 ` Meelis Roos
2017-07-11 15:38   ` Don Brace
2017-07-11 15:58     ` Meelis Roos
2017-07-12  7:11       ` Christoph Hellwig [this message]
2017-07-12  7:12         ` Hannes Reinecke
2017-08-02 15:05   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712071121.GA5545@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=don.brace@microsemi.com \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox