From: Johannes Thumshirn <jthumshirn@suse.de>
To: Song Liu <songliubraving@fb.com>
Cc: linux-scsi@vger.kernel.org, hare@suse.de,
James.Bottomley@HansenPartnership.com, axboe@fb.com,
axboe@kernel.dk, bblock@linux.vnet.ibm.com, emilne@redhat.com
Subject: Re: [RFC v3 1/2] scsi: generate uevent for SCSI sense code
Date: Thu, 13 Jul 2017 08:39:57 +0200 [thread overview]
Message-ID: <20170713063957.GA5212@linux-x5ow.site> (raw)
In-Reply-To: <20170712223535.2609814-2-songliubraving@fb.com>
On Wed, Jul 12, 2017 at 03:35:34PM -0700, Song Liu wrote:
> + if (!test_bit(sshdr->sense_key & 0xf,
> + &sdev->sense_event_filter))
While being technically correct, this looks a bit kludgy. Please pass
in the whole sense_key without masking it.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-07-13 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 22:35 [RFC v3 0/2] generate uevent for SCSI sense code Song Liu
2017-07-12 22:35 ` [RFC v3 1/2] scsi: " Song Liu
2017-07-13 6:39 ` Johannes Thumshirn [this message]
2017-07-12 22:35 ` [RFC v3 2/2] scsi: add rate limit to scsi sense code uevent Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713063957.GA5212@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=bblock@linux.vnet.ibm.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox