From: Mike Snitzer <snitzer@redhat.com>
To: hch@lst.de
Cc: dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: [for-4.14 RFC PATCH 0/2] dm rq: eliminate historic blk-mq and .request_fn queue stacking restrictions
Date: Thu, 13 Jul 2017 17:12:15 -0400 [thread overview]
Message-ID: <20170713211217.52361-1-snitzer@redhat.com> (raw)
Hi,
Please review the 2 patches in this series. I'm left on-the-fence
about whether there is any point re-enabling "dm-mq stacked on old
.request_fn device(s)" -- especially given the awkward details
documented in the 1/2 patch header.
I welcome any feedback on this, thanks!
BTW, I tested these changes using mptest:
git://github.com/snitm/mptest.git
with the following permutations ('runtest' script tweaked before each
permutation):
echo N > /sys/module/scsi_mod/parameters/use_blk_mq
echo N > /sys/module/dm_mod/parameters/use_blk_mq
echo Y > /sys/module/scsi_mod/parameters/use_blk_mq
echo Y > /sys/module/dm_mod/parameters/use_blk_mq
echo Y > /sys/module/scsi_mod/parameters/use_blk_mq
echo N > /sys/module/dm_mod/parameters/use_blk_mq
echo N > /sys/module/scsi_mod/parameters/use_blk_mq
echo Y > /sys/module/dm_mod/parameters/use_blk_mq
Mike Snitzer (2):
dm rq: avoid deadlock if dm-mq is stacked on old .request_fn device(s)
dm rq: eliminate historic blk-mq and .request_fn queue stacking restrictions
drivers/md/dm-mpath.c | 16 ++++++++++++++--
drivers/md/dm-rq.c | 13 +++++--------
drivers/md/dm-table.c | 31 +++----------------------------
drivers/md/dm-target.c | 4 ++--
drivers/md/dm.h | 1 -
include/linux/device-mapper.h | 3 ++-
6 files changed, 26 insertions(+), 42 deletions(-)
--
2.10.1
next reply other threads:[~2017-07-13 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:12 Mike Snitzer [this message]
2017-07-13 21:12 ` [for-4.14 RFC PATCH 1/2] dm rq: avoid deadlock if dm-mq is stacked on old .request_fn device(s) Mike Snitzer
2017-07-14 7:22 ` Christoph Hellwig
2017-07-14 14:19 ` Mike Snitzer
2017-07-14 17:17 ` Ewan D. Milne
2017-07-14 21:15 ` Mike Snitzer
2017-07-13 21:12 ` [for-4.14 RFC PATCH 2/2] dm rq: eliminate historic blk-mq and .request_fn queue stacking restrictions Mike Snitzer
2017-07-14 7:12 ` [for-4.14 RFC PATCH 0/2] " Christoph Hellwig
2017-07-14 14:02 ` Mike Snitzer
2017-07-15 8:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713211217.52361-1-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox