From: Johannes Thumshirn <jthumshirn@suse.de>
To: Jason L Tibbitts III <tibbs@math.uh.edu>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
dvyukov@google.com, hare@suse.com, hch@lst.de,
martin.petersen@oracle.com
Subject: Re: [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control
Date: Tue, 18 Jul 2017 09:37:47 +0200 [thread overview]
Message-ID: <20170718073747.GD4875@linux-x5ow.site> (raw)
In-Reply-To: <ufafudubmkd.fsf@epithumia.math.uh.edu>
On Mon, Jul 17, 2017 at 07:44:50PM -0500, Jason L Tibbitts III wrote:
> and confirmed that clean unpatched 4.12 shows the problem, while
> reverting just that patch fixes the issue. Unfortunately I don't know
> enough to actually fix this, but I can easily test patches.
This is fixed with:
commit 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47
Author: Johannes Thumshirn <jthumshirn@suse.de>
Date: Fri Jul 7 10:56:38 2017 +0200
scsi: sg: fix SG_DXFER_FROM_DEV transfers
SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set
it to NULL for the old sg_io read/write interface, but must have a
length bigger than 0. This fixes a regression introduced by commit
28676d869bbb ("scsi: sg: check for valid direction before starting the
request")
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the request")
Reported-by: Chris Clayton <chris2553@googlemail.com>
Tested-by: Chris Clayton <chris2553@googlemail.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Tested-by: Chris Clayton <chris2553@googlemail.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-07-18 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 0:44 [REGRESSION] 28676d869bbb (scsi: sg: check for valid direction before starting the request) breaks mtx tape library control Jason L Tibbitts III
2017-07-18 7:37 ` Johannes Thumshirn [this message]
2017-07-18 16:53 ` Jason L Tibbitts III
2017-07-18 17:33 ` Jason L Tibbitts III
2017-07-19 7:03 ` Johannes Thumshirn
2017-07-19 8:13 ` Jason L Tibbitts III
2017-07-19 8:36 ` Johannes Thumshirn
2017-07-21 16:43 ` Johannes Thumshirn
2017-07-21 19:23 ` Jason L Tibbitts III
2017-07-25 7:18 ` Johannes Thumshirn
2017-07-25 18:25 ` Jason L Tibbitts III
2017-07-26 7:39 ` Johannes Thumshirn
2017-07-26 20:19 ` Jason L Tibbitts III
2017-07-25 19:09 ` Douglas Gilbert
2017-07-26 7:22 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718073747.GD4875@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=dvyukov@google.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tibbs@math.uh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox