Re: [PATCH 4/7] qla2xxx: Added change to enable ZIO for FC-NVMe devices

Madhani, Himanshu
2017-07-20T16:55:45Z

> On Jul 20, 2017, at 12:00 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
>
> On Wed, Jul 19, 2017 at 11:51:48AM -0700, Himanshu Madhani wrote:
>> + mcp->out_mb = MBX_2|MBX_1|MBX_0;
>> + mcp->in_mb = MBX_2|MBX_0;
>
> Please add spaces around the '|'. Checkpatch should've warned you about that.
>

Sure.

>> + mcp->tov = MBX_TOV_SECONDS;
>> + mcp->flags = 0;
>> +
>> + rval = qla2x00_mailbox_command(vha, mcp);
>> + if (rval != QLA_SUCCESS) {
>> + ql_dbg(ql_dbg_mbx, vha, 0x1201, "Failed=%x.\n", rval);
>> + } else {
>> + ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x1202,
>> + "Done %s.\n", __func__);
>> + }
>
> In patch 1 you change all the
> if (rval != QLA_SUCCESS) {
> qla_dbg();
> } else {
> qla_dbg();
> }
> into a single qla_dbg. Now you re-introduce the pattern here.
>

Good catch.. somehow this missed my eye. I’ll fix in v2 of this series.

>
>> +int qla27xx_get_zio_threshold(scsi_qla_host_t *vha, uint16_t *value)
>
> See above comment
>
> Thanks,
> Johannes
> --
> Johannes Thumshirn Storage
> jthumshirn@suse.de +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thanks,
- Himanshu