Re: [PATCH 3/7] qla2xxx: Add command completion wq for error path

Madhani, Himanshu
2017-07-20T17:17:36Z

Hi Bart,

> On Jul 19, 2017, at 1:46 PM, Bart Van Assche <bart.vanassche@wdc.com> wrote:
>
> On Wed, 2017-07-19 at 11:51 -0700, Himanshu Madhani wrote:
>> From: Duane Grigsby <duane.grigsby@cavium.com>
>
> Hello Himanshu and Duane,
>
> Too many drivers create workqueues for all kinds of purposes. Why is it
> necessary to execute qla_nvme_io_work() on the context of a new workqueue?
> If any of the existing system workqueues can be used please modify the patch
> accordingly. Otherwise please explain why it is necessary to introduce a new
> workqueue.
>
> Bart.

Good point. We went with this approach so that we could release qpair lock on a
particular queue when we get error. however, we’ll rework this patch and submit
it again to use one of already existing work queue.

Thanks,
- Himanshu