From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH 1/7] qla2xxx: Cleanup NVMe code. Date: Thu, 20 Jul 2017 08:40:57 +0200 Message-ID: <20170720064057.GB5240@linux-x5ow.site> References: <20170719185151.8564-1-himanshu.madhani@cavium.com> <20170719185151.8564-2-himanshu.madhani@cavium.com> <1500497052.2494.7.camel@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:33540 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751810AbdGTGk7 (ORCPT ); Thu, 20 Jul 2017 02:40:59 -0400 Content-Disposition: inline In-Reply-To: <1500497052.2494.7.camel@wdc.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: "James.Bottomley@HansenPartnership.com" , "himanshu.madhani@cavium.com" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" On Wed, Jul 19, 2017 at 08:44:13PM +0000, Bart Van Assche wrote: > "cleaned up code" is a very vague description. Please be more specific and > please also mention in the patch description what functionality has been > changed (if any). Hi Bart, These are just some style changes I requested when reviewing the last patchset. But I agree at least a "no functional changes introduced" would be very beneficial. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850