From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: QLogic-Storage-Upstream@qlogic.com, martin.petersen@oracle.com,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code
Date: Mon, 24 Jul 2017 12:52:55 +0200 [thread overview]
Message-ID: <20170724105255.715647116@linutronix.de> (raw)
The conversion of the cpu hotplug locking to a percpu rwsem does not longer
allow recursive locking of the hotplug lock.
The BNX2I and BNX2FC drivers install/remove hotplug states with the hotplug
lock held. The install/removal code acquired the hotplug lock as well.
While looking into this, I noticed an interesting hotplug race in the
BNX2FC driver, which could result in dereferencing a NULL pointer or freed
and potentially reused memory.
The following series addresses these problems and as a final step on top it
simplifies the hotplug code in both drivers.
Thanks,
tglx
----
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 68 ++++++++------------------------------
drivers/scsi/bnx2fc/bnx2fc_hwi.c | 45 ++++++++++++-------------
drivers/scsi/bnx2i/bnx2i_init.c | 64 ++++++++---------------------------
include/linux/cpuhotplug.h | 2 -
4 files changed, 53 insertions(+), 126 deletions(-)
next reply other threads:[~2017-07-24 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 10:52 Thomas Gleixner [this message]
2017-07-24 10:52 ` [patch 1/5] scsi/bnx2fc: Plug CPU hotplug race Thomas Gleixner
2017-07-24 10:52 ` [patch 2/5] scsi/bnx2fc: Prevent recursive cpuhotplug locking Thomas Gleixner
2017-07-24 10:52 ` [patch 3/5] scsi/bnx2i: " Thomas Gleixner
2017-07-31 22:09 ` Steven Rostedt
2017-07-24 10:52 ` [patch 4/5] scsi/bnx2fc: Simplify CPU hotplug code Thomas Gleixner
2017-07-24 10:53 ` [patch 5/5] scsi/bnx2i: Simplify cpu " Thomas Gleixner
2017-07-25 13:27 ` [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify " Chad Dupuis
2017-07-27 1:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724105255.715647116@linutronix.de \
--to=tglx@linutronix.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox