public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: Dick Kennedy <dick.kennedy@broadcom.com>,
	James Smart <james.smart@broadcom.com>
Subject: [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled
Date: Wed,  2 Aug 2017 16:36:28 -0700	[thread overview]
Message-ID: <20170802233648.4573-2-jsmart2021@gmail.com> (raw)
In-Reply-To: <20170802233648.4573-1-jsmart2021@gmail.com>

From: Dick Kennedy <dick.kennedy@broadcom.com>

Null pointer dereference in lpfc_sli4_fof_intr_handler

The driver does not set up cq->assoc_qp for sli4_hba->oas_cq

Initialize cq->assoc_qp before accessing it

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_sli.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index e948ea05fd33..0615bf9def23 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -13557,6 +13557,9 @@ lpfc_sli4_fof_handle_eqe(struct lpfc_hba *phba, struct lpfc_eqe *eqe)
 	/* Save EQ associated with this CQ */
 	cq->assoc_qp = phba->sli4_hba.fof_eq;
 
+	/* Save EQ associated with this CQ */
+	cq->assoc_qp = phba->sli4_hba.fof_eq;
+
 	/* Process all the entries to the OAS CQ */
 	while ((cqe = lpfc_sli4_cq_get(cq))) {
 		workposted |= lpfc_sli4_fp_handle_cqe(phba, cq, cqe);
-- 
2.13.1

  reply	other threads:[~2017-08-02 23:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 23:36 [PATCH 00/21] lpfc updates for 11.4.0.3 James Smart
2017-08-02 23:36 ` James Smart [this message]
2017-08-03 10:43   ` [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled Nikola Pajkovsky
2017-08-05  0:36     ` James Smart
2017-08-02 23:36 ` [PATCH 02/21] lpfc: Fix plogi collision that causes illegal state transition James Smart
2017-08-02 23:36 ` [PATCH 03/21] lpfc: Fix loop mode target discovery James Smart
2017-08-02 23:36 ` [PATCH 04/21] lpfc: Fix rediscovery on switch blade pull James Smart
2017-08-02 23:36 ` [PATCH 05/21] lpfc: Fix oops when NVME Target is discovered in a nonNVME environment James Smart
2017-08-02 23:36 ` [PATCH 06/21] lpfc: convert info messages to standard messages James Smart
2017-08-02 23:36 ` [PATCH 07/21] lpfc: Correct return error codes to align with nvme_fc transport James Smart
2017-08-02 23:36 ` [PATCH 08/21] lpfc: Fix handling of FCP and NVME FC4 types in Pt2Pt topology James Smart
2017-08-02 23:36 ` [PATCH 09/21] lpfc: Fix duplicate NVME rport entries and namespaces James Smart
2017-08-02 23:36 ` [PATCH 10/21] lpfc: Fix crash in lpfc nvmet when fc port is reset James Smart
2017-08-02 23:36 ` [PATCH 11/21] lpfc: Fix NVME PRLI handling during RSCN James Smart
2017-08-02 23:36 ` [PATCH 12/21] lpfc: Correct issues with FAWWN and FDISCs James Smart
2017-08-02 23:36 ` [PATCH 13/21] lpfc: Limit amount of work processed in IRQ James Smart
2017-08-02 23:36 ` [PATCH 14/21] lpfc: Fix MRQ > 1 context list handling James Smart
2017-08-02 23:36 ` [PATCH 15/21] lpfc: Fix relative offset error on large nvmet target ios James Smart
2017-08-02 23:36 ` [PATCH 16/21] lpfc: Fix nvme target failure after 2nd adapter reset James Smart
2017-08-02 23:36 ` [PATCH 17/21] lpfc: Fix bad sgl reposting " James Smart
2017-08-02 23:36 ` [PATCH 18/21] lpfc: remove console log clutter James Smart
2017-08-02 23:36 ` [PATCH 19/21] lpfc: Add Buffer to Buffer credit recovery support James Smart
2017-08-02 23:36 ` [PATCH 20/21] lpfc: Add new adapter type 6 support James Smart
2017-08-02 23:36 ` [PATCH 21/21] lpfc: lpfc version bump 11.4.0.3 James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802233648.4573-2-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox