public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices
Date: Sat, 5 Aug 2017 13:35:23 +0200	[thread overview]
Message-ID: <20170805113523.GC16313@lst.de> (raw)
In-Reply-To: <1501828660-89497-1-git-send-email-hare@suse.de>

>  	error = scsi_dh_add_device(sdev);
> -	if (error)
> -		/*
> -		 * device_handler is optional, so any error can be ignored
> -		 */
> -		sdev_printk(KERN_INFO, sdev,
> -				"failed to add device handler: %d\n", error);
> +	/* device_handler is optional, so any error can be ignored */

In that case it should return void.

  parent reply	other threads:[~2017-08-05 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04  6:37 [PATCH] scsi_dh_alua: suppress errors from unsupported devices Hannes Reinecke
2017-08-04  7:11 ` Johannes Thumshirn
2017-08-04 15:56 ` Bart Van Assche
2017-08-05 11:35 ` Christoph Hellwig [this message]
2017-08-07  6:07   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170805113523.GC16313@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox