From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH v2 08/20] lpfc: Fix duplicate NVME rport entries and namespaces. Date: Mon, 7 Aug 2017 10:33:40 +0200 Message-ID: <20170807083340.GL3978@linux-x5ow.site> References: <20170805004731.1335-1-jsmart2021@gmail.com> <20170805004731.1335-9-jsmart2021@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:41528 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752232AbdHGIdq (ORCPT ); Mon, 7 Aug 2017 04:33:46 -0400 Content-Disposition: inline In-Reply-To: <20170805004731.1335-9-jsmart2021@gmail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Smart Cc: linux-scsi@vger.kernel.org, Dick Kennedy , James Smart On Fri, Aug 04, 2017 at 05:47:19PM -0700, James Smart wrote: > + /* For nvme, swap the nrport. */ > + keep_nrport = new_ndlp->nrport; > + new_ndlp->nrport = ndlp->nrport; > + The above comment did trigger a "Please use the swap() macro" warning in my brain, which isn't applicable here. Can we maybe reprase it to something like: /* For NVMe, cache new_ndlp->nrport and override with ndlp->nrport */ Otherwise, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850