From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>, "hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: sd_zbc: Disable zoned block devices with scsi-mq
Date: Mon, 21 Aug 2017 17:33:51 +0200 [thread overview]
Message-ID: <20170821153351.GB20205@lst.de> (raw)
In-Reply-To: <1502982108.2615.1.camel@wdc.com>
On Thu, Aug 17, 2017 at 03:01:51PM +0000, Bart Van Assche wrote:
> Another possible approach is to fix the ipr driver and to resubmit the
> "scsi-mq: Always unprepare before requeuing a request" and "scsi: sd_zbc:
> Write unlock zone from sd_uninit_cmnd()" patches.
We should absolutely take that broader approach.
But it seems like we need to refne the always unprepare patch first,
to make sure we only release resources, but don't clear the
scmd->retries field. The NVMe driver already works that way, so
we have an example to follow.
next prev parent reply other threads:[~2017-08-21 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 2:45 [PATCH] scsi: sd_zbc: Disable zoned block devices with scsi-mq Damien Le Moal
2017-08-17 7:59 ` Christoph Hellwig
2017-08-17 12:19 ` Damien Le Moal
2017-08-17 12:24 ` Damien Le Moal
2017-08-17 15:01 ` Bart Van Assche
2017-08-18 0:21 ` Damien Le Moal
2017-08-21 15:33 ` hch [this message]
2017-08-21 20:31 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821153351.GB20205@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox