Re: [PATCH 07/19] Fix RCU handling of scsi_device.vpd_pg8[03]

Christoph Hellwig
2017-08-24T09:07:19Z

On Wed, Aug 23, 2017 at 02:39:57PM -0700, Bart Van Assche wrote:
> Only annotate pointers that are shared across threads with __rcu.
> Use rcu_dereference() when dereferencing an RCU pointer. Protect
> also the RCU pointer dereferences when freeing RCU pointers. This
> patch suppresses about twenty sparse complaints about the vpd_pg8[03]
> pointers.

Shouldn't the kfrees be kfree_rcu? or where else is the rcu protection
for them?