Re: [PATCH 15/19] libsas: Annotate fall-through in a switch statement

Hannes Reinecke
2017-08-25T15:52:32Z

On 08/23/2017 11:40 PM, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/libsas/sas_ata.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 87f5e694dbed..70be4425ae0b 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -343,6 +343,7 @@ static int smp_ata_check_ready(struct ata_link *link)
> case SAS_END_DEVICE:
> if (ex_phy->attached_sata_dev)
> return sas_ata_clear_pending(dev, ex_phy);
> + /* fall through */
> default:
> return -ENODEV;
> }
>
We should be coming to a consensus on how 'fallthrough' is spelled...
Other than that:

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)