Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

hch
2017-08-25T15:29:33Z

On Thu, Aug 24, 2017 at 04:27:07PM +0000, Bart Van Assche wrote:
>
> The purpose of that check is to avoid that dev_loss_tmo * HZ can overflow.
> That check is only needed on 32-bit systems since only on these systems
> sizeof(long) == sizeof(int). How about changing the type of the dev_loss_tmo
> argument from int to long such that no explicit cast is needed?

Yes, switching the timeout to long sounds useful as that's our normal
type for timeouts. But it will spread through a lot of the SRP code.