From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@lst.de" <hch@lst.de>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"brking@linux.vnet.ibm.com" <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH] Improve requeuing behavior
Date: Thu, 24 Aug 2017 18:57:04 +0200 [thread overview]
Message-ID: <20170824165704.GA28901@lst.de> (raw)
In-Reply-To: <1503591261.2702.9.camel@wdc.com>
On Thu, Aug 24, 2017 at 04:14:22PM +0000, Bart Van Assche wrote:
> Commit ca18d6f769d2 ("block: Make most scsi_req_init() calls implicit")
> introduced the scsi_initialize_rq() function in such a way that it is not only
> called for pass-through requests but also for FS requests. Because that commit
> sets .initialize_rq_fn for both blk-sq and blk-mq blk_get_request() now calls
> scsi_initialize_rq() for all SCSI requests. Or did I perhaps overlook something?
initialize_rq_fn is only called from blk_get_request, which is not
called for normal file system read/write/flush/discard request.
Also unless my memory fails me that's something that I and Jens requested
to be changed from your original version.
next prev parent reply other threads:[~2017-08-24 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 21:05 [PATCH] Improve requeuing behavior Bart Van Assche
2017-08-24 12:09 ` Christoph Hellwig
2017-08-24 16:14 ` Bart Van Assche
2017-08-24 16:57 ` hch [this message]
2017-08-24 17:17 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824165704.GA28901@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox