From: Christoph Hellwig <hch@lst.de>
To: Chaitra Basappa <chaitra.basappa@broadcom.com>,
linux-scsi@vger.kernel.org
Cc: Bart Van Assche <bart.vanassche@wdc.com>
Subject: [PATCH 3/4] smartpqi: remove the smp_handler stub
Date: Fri, 25 Aug 2017 17:37:40 +0200 [thread overview]
Message-ID: <20170825153741.5091-4-hch@lst.de> (raw)
In-Reply-To: <20170825153741.5091-1-hch@lst.de>
The SAS transport class will do the right thing and not register the BSG
node if now smp_handler method is present.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/smartpqi/smartpqi_sas_transport.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_sas_transport.c b/drivers/scsi/smartpqi/smartpqi_sas_transport.c
index 0d89d3728b43..b209a35e482e 100644
--- a/drivers/scsi/smartpqi/smartpqi_sas_transport.c
+++ b/drivers/scsi/smartpqi/smartpqi_sas_transport.c
@@ -329,14 +329,6 @@ static int pqi_sas_phy_speed(struct sas_phy *phy,
return -EINVAL;
}
-/* SMP = Serial Management Protocol */
-
-static int pqi_sas_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy,
- struct request *req)
-{
- return -EINVAL;
-}
-
struct sas_function_template pqi_sas_transport_functions = {
.get_linkerrors = pqi_sas_get_linkerrors,
.get_enclosure_identifier = pqi_sas_get_enclosure_identifier,
@@ -346,5 +338,4 @@ struct sas_function_template pqi_sas_transport_functions = {
.phy_setup = pqi_sas_phy_setup,
.phy_release = pqi_sas_phy_release,
.set_phy_speed = pqi_sas_phy_speed,
- .smp_handler = pqi_sas_smp_handler,
};
--
2.11.0
next prev parent reply other threads:[~2017-08-25 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 15:37 [RFC] switch the SAS transport class to bsg-lib Christoph Hellwig
2017-08-25 15:37 ` [PATCH 1/4] bsg-lib: pass the release callback through bsg_setup_queue Christoph Hellwig
2017-08-29 11:31 ` Johannes Thumshirn
2017-08-25 15:37 ` [PATCH 2/4] hpsa: remove the smp_handler stub Christoph Hellwig
2017-08-28 18:41 ` Don Brace
2017-08-29 11:32 ` Johannes Thumshirn
2017-08-25 15:37 ` Christoph Hellwig [this message]
2017-08-29 11:32 ` [PATCH 3/4] smartpqi: " Johannes Thumshirn
2017-08-25 15:37 ` [PATCH 4/4] scsi_transport_sas: switch to bsg-lib for SMP passthrough Christoph Hellwig
2017-08-29 11:50 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825153741.5091-4-hch@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@wdc.com \
--cc=chaitra.basappa@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox