From: Bart Van Assche <bart.vanassche@wdc.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bart.vanassche@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Shane M Seymour <shane.seymour@hpe.com>
Subject: [PATCH v3 1/3] rcu: Introduce rcu_swap_protected()
Date: Mon, 28 Aug 2017 13:44:40 -0700 [thread overview]
Message-ID: <20170828204446.29066-2-bart.vanassche@wdc.com> (raw)
In-Reply-To: <20170828204446.29066-1-bart.vanassche@wdc.com>
A common pattern in RCU code is to assign a new value to an RCU
pointer after having read and stored the old value. Introduce a
macro for this pattern.
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Shane M Seymour <shane.seymour@hpe.com>
---
include/linux/rcupdate.h | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index f816fc72b51e..555815ce2e57 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -561,6 +561,26 @@ static inline void rcu_preempt_sleep_check(void) { }
*/
#define rcu_pointer_handoff(p) (p)
+/**
+ * rcu_swap_protected() - swap an RCU and a regular pointer
+ * @rcu_ptr: RCU pointer
+ * @ptr: regular pointer
+ * @c: the conditions under which the dereference will take place
+ *
+ * Perform swap(@rcu_ptr, @ptr) where @rcu_ptr is an RCU-annotated pointer and
+ * @c is the argument that is passed to the rcu_dereference_protected() call
+ * used to read that pointer.
+ */
+#define rcu_swap_protected(rcu_ptr, ptr, c) do { \
+ typeof(ptr) __tmp; \
+ \
+ BUILD_BUG_ON(!__same_type(typeof(rcu_ptr), typeof(*(ptr)) __rcu *)); \
+ BUILD_BUG_ON(!__same_type(typeof(ptr), typeof(*(rcu_ptr)) *)); \
+ __tmp = rcu_dereference_protected((rcu_ptr), (c)); \
+ rcu_assign_pointer((rcu_ptr), (ptr)); \
+ (ptr) = __tmp; \
+} while (0)
+
/**
* rcu_read_lock() - mark the beginning of an RCU read-side critical section
*
--
2.14.1
next prev parent reply other threads:[~2017-08-28 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 20:44 [PATCH v3 0/3] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-28 20:44 ` Bart Van Assche [this message]
2017-08-28 20:44 ` [PATCH v3 2/3] Rework the code for caching Vital Product Data (VPD) Bart Van Assche
2017-08-28 20:44 ` [PATCH v3 3/3] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-28 20:44 ` [PATCH v3 0/3] " Bart Van Assche
2017-08-28 20:44 ` [PATCH v3 1/3] rcu: Introduce rcu_swap_protected() Bart Van Assche
2017-08-28 20:44 ` [PATCH v3 2/3] Rework the code for caching Vital Product Data (VPD) Bart Van Assche
2017-08-28 20:44 ` [PATCH v3 3/3] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-28 20:46 ` [PATCH v3 0/3] " Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-08-28 20:45 Bart Van Assche
2017-08-28 20:45 ` [PATCH v3 1/3] rcu: Introduce rcu_swap_protected() Bart Van Assche
2017-08-28 20:45 ` Bart Van Assche
2017-08-28 20:46 [PATCH v3 0/3] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-28 20:46 ` [PATCH v3 1/3] rcu: Introduce rcu_swap_protected() Bart Van Assche
2017-08-28 21:26 ` Paul E. McKenney
2017-08-28 21:39 ` Bart Van Assche
2017-08-28 21:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828204446.29066-2-bart.vanassche@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shane.seymour@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox