From mboxrd@z Thu Jan 1 00:00:00 1970 From: Varun Prakash Subject: Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk Date: Mon, 11 Sep 2017 14:51:59 +0530 Message-ID: <20170911092156.GA1721@chelsio.com> References: <20170907135133.16636-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from stargate.chelsio.com ([12.32.117.8]:9284 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdIKJWI (ORCPT ); Mon, 11 Sep 2017 05:22:08 -0400 Content-Disposition: inline In-Reply-To: <20170907135133.16636-1-colin.king@canonical.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Colin King Cc: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Sep 07, 2017 at 02:51:33PM +0100, Colin King wrote: > From: Colin Ian King > > csk is always null on the error return path and so the non-null > check and call to cxgbi_sock_closed on csk is redundant and > can be removed. > > Detected by: CoverityScan CID#114329 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/scsi/cxgbi/libcxgbi.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c > index 512c8f1ea5b0..da36c2de069e 100644 > --- a/drivers/scsi/cxgbi/libcxgbi.c > +++ b/drivers/scsi/cxgbi/libcxgbi.c > @@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex) > > rel_rt: > ip_rt_put(rt); > - if (csk) > - cxgbi_sock_closed(csk); > err_out: > return ERR_PTR(err); > } Acked-by: Varun Prakash