From: Christoph Hellwig <hch@infradead.org>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: aacraid@microsemi.com, linux-scsi@vger.kernel.org,
RaghavaAditya.Renukunta@microsemi.com,
david.carroll@microsemi.com, brking@linux.vnet.ibm.com,
dougmill@linux.vnet.ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: aacraid: Add a small delay after IOP reset
Date: Tue, 19 Sep 2017 08:37:12 -0700 [thread overview]
Message-ID: <20170919153712.GA15496@infradead.org> (raw)
In-Reply-To: <20170919151156.29412-1-gpiccoli@linux.vnet.ibm.com>
On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote:
> src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK);
> +
> + msleep(5000);
src_writel is a writel, and thus a posted MMIO write. You'll need
to have to a read first to make it a reliable timing base.
next prev parent reply other threads:[~2017-09-19 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:11 [PATCH] scsi: aacraid: Add a small delay after IOP reset Guilherme G. Piccoli
2017-09-19 15:37 ` Christoph Hellwig [this message]
2017-09-19 15:49 ` Guilherme G. Piccoli
2017-09-19 15:52 ` Christoph Hellwig
2017-09-19 15:58 ` Guilherme G. Piccoli
2017-09-19 17:05 ` James Bottomley
2017-09-19 19:15 ` Guilherme G. Piccoli
2017-09-21 16:19 ` Dave Carroll
2017-09-25 21:09 ` Guilherme G. Piccoli
2017-09-25 21:34 ` Martin K. Petersen
2017-09-27 19:26 ` Dave Carroll
2017-09-28 1:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919153712.GA15496@infradead.org \
--to=hch@infradead.org \
--cc=RaghavaAditya.Renukunta@microsemi.com \
--cc=aacraid@microsemi.com \
--cc=brking@linux.vnet.ibm.com \
--cc=david.carroll@microsemi.com \
--cc=dougmill@linux.vnet.ibm.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox