* Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device [not found] ` <20170914173843.3195-2-jsmart2021@gmail.com> @ 2017-09-18 16:13 ` Christoph Hellwig 2017-09-20 10:30 ` Johannes Thumshirn 0 siblings, 1 reply; 4+ messages in thread From: Christoph Hellwig @ 2017-09-18 16:13 UTC (permalink / raw) To: James Smart; +Cc: linux-nvme, James Smart, Johannes Thumshirn, linux-scsi Looks ok, although I really wish we could come up with some common FC code, including making the existing FC drivers use more infrastructure from libfc.. Reviewed-by: Christoph Hellwig <hch@lst.de> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device 2017-09-18 16:13 ` [PATCH v3 1/3] nvme_fc: create fc class and transport device Christoph Hellwig @ 2017-09-20 10:30 ` Johannes Thumshirn 2017-09-20 17:50 ` Christoph Hellwig 0 siblings, 1 reply; 4+ messages in thread From: Johannes Thumshirn @ 2017-09-20 10:30 UTC (permalink / raw) To: Christoph Hellwig; +Cc: James Smart, linux-nvme, James Smart, linux-scsi On Mon, Sep 18, 2017 at 09:13:30AM -0700, Christoph Hellwig wrote: > Looks ok, > > although I really wish we could come up with some common FC code, > including making the existing FC drivers use more infrastructure > from libfc.. the problem with libfc currently is it is made for fcoe, despite being named libfc. The other hand it is hard-wired to FCP so bringing NVMe into it is a bit challanging, BTDT. It's not that it is impossible, it's just not something that can be done in a day or two of hacking. Anyways, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device 2017-09-20 10:30 ` Johannes Thumshirn @ 2017-09-20 17:50 ` Christoph Hellwig 2017-09-21 5:16 ` Johannes Thumshirn 0 siblings, 1 reply; 4+ messages in thread From: Christoph Hellwig @ 2017-09-20 17:50 UTC (permalink / raw) To: Johannes Thumshirn Cc: Christoph Hellwig, James Smart, James Smart, linux-nvme, linux-scsi On Wed, Sep 20, 2017 at 12:30:41PM +0200, Johannes Thumshirn wrote: > the problem with libfc currently is it is made for fcoe, despite being named > libfc. Well, that's my point - we should be able to use more bits in a common FC layer. I don't really care about the exact name. > The other hand it is hard-wired to FCP so bringing NVMe into it is a > bit challanging, BTDT. FC-NVMe layers on top of FCP. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device 2017-09-20 17:50 ` Christoph Hellwig @ 2017-09-21 5:16 ` Johannes Thumshirn 0 siblings, 0 replies; 4+ messages in thread From: Johannes Thumshirn @ 2017-09-21 5:16 UTC (permalink / raw) To: Christoph Hellwig; +Cc: James Smart, James Smart, linux-nvme, linux-scsi On Wed, Sep 20, 2017 at 10:50:18AM -0700, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 12:30:41PM +0200, Johannes Thumshirn wrote: > > the problem with libfc currently is it is made for fcoe, despite being named > > libfc. > > Well, that's my point - we should be able to use more bits in a common > FC layer. I don't really care about the exact name. Yes, that's on my long term TODO list, getting rid of the SKBs used internally so ibmvfc can be switched over, allow the setting of the NVMe Type code (or even arbitrary typecodes) yada, yada. It'll benefit fnic, bnx2fc and qedfc as well, but I haven't been able to do much in this regard. Hannes and I have internal patchsets flying around solving the fist little bits for it but they're far from completion. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-21 5:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170914173843.3195-1-jsmart2021@gmail.com>
[not found] ` <20170914173843.3195-2-jsmart2021@gmail.com>
2017-09-18 16:13 ` [PATCH v3 1/3] nvme_fc: create fc class and transport device Christoph Hellwig
2017-09-20 10:30 ` Johannes Thumshirn
2017-09-20 17:50 ` Christoph Hellwig
2017-09-21 5:16 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox