From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH V7 3/6] block: pass flags to blk_queue_enter() Date: Tue, 3 Oct 2017 15:21:45 +0800 Message-ID: <20171003072144.GA23235@ming.t460p> References: <20170930061214.10622-1-ming.lei@redhat.com> <20170930061214.10622-4-ming.lei@redhat.com> <20171002134032.GC19119@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171002134032.GC19119@infradead.org> Sender: linux-block-owner@vger.kernel.org To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, "Martin K . Petersen" , "James E . J . Bottomley" , Bart Van Assche , Oleksandr Natalenko , Johannes Thumshirn , Cathy Avery , Martin Steigerwald , linux-kernel@vger.kernel.org, Hannes Reinecke , Bart Van Assche List-Id: linux-scsi@vger.kernel.org On Mon, Oct 02, 2017 at 06:40:32AM -0700, Christoph Hellwig wrote: > On Sat, Sep 30, 2017 at 02:12:11PM +0800, Ming Lei wrote: > > We need to pass PREEMPT flags to blk_queue_enter() > > for allocating request with RQF_PREEMPT in the > > following patch. > > I don't like having another name space for flags. It seems like > we should simply pass ops on, and then map the nowait allocations > to RQF_PREEMPT to REQ_PREEMPT as done in the series from Bart. OK, no problem, will integrate Bart's patches in this patchset. -- Ming