From: Christoph Hellwig <hch@lst.de>
To: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Benjamin Block <bblock@linux.vnet.ibm.com>
Subject: [PATCH 5/9] scsi_transport_sas: check reply payload length instead of bidi request
Date: Tue, 3 Oct 2017 12:48:41 +0200 [thread overview]
Message-ID: <20171003104845.10417-6-hch@lst.de> (raw)
In-Reply-To: <20171003104845.10417-1-hch@lst.de>
As a user of bsg-lib the SAS transport should not poke into request
internals but use the bsg_job fields instead.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/scsi_transport_sas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 319dff970237..736a1f4f9676 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -177,7 +177,7 @@ static int sas_smp_dispatch(struct bsg_job *job)
if (!scsi_is_host_device(job->dev))
rphy = dev_to_rphy(job->dev);
- if (!job->req->next_rq) {
+ if (!job->reply_payload.payload_len) {
dev_warn(job->dev, "space for a smp response is missing\n");
bsg_job_done(job, -EINVAL, 0);
return 0;
--
2.14.1
next prev parent reply other threads:[~2017-10-03 10:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 10:48 [RFC] bsg-lib interface cleanup Christoph Hellwig
2017-10-03 10:48 ` [PATCH 1/9] bsg-lib: fix use-after-free under memory-pressure Christoph Hellwig
2017-10-04 6:16 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 2/9] bfa: don't reset max_segments for every bsg request Christoph Hellwig
2017-10-04 6:16 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 3/9] libfc: don't assign resid_len in fc_lport_bsg_request Christoph Hellwig
2017-10-04 6:17 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions Christoph Hellwig
2017-10-04 6:20 ` Hannes Reinecke
2017-10-04 8:54 ` Johannes Thumshirn
2017-10-05 16:58 ` Madhani, Himanshu
2017-10-03 10:48 ` Christoph Hellwig [this message]
2017-10-04 6:21 ` [PATCH 5/9] scsi_transport_sas: check reply payload length instead of bidi request Hannes Reinecke
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-03 10:48 ` [PATCH 6/9] bsg-lib: introduce a timeout field in struct bsg_job Christoph Hellwig
2017-10-04 6:21 ` Hannes Reinecke
2017-10-04 8:53 ` Johannes Thumshirn
2017-10-16 16:30 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 7/9] bsg-lib: remove bsg_job.req Christoph Hellwig
2017-10-04 6:22 ` Hannes Reinecke
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-16 16:36 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 8/9] block: pass full fmode_t to blk_verify_command Christoph Hellwig
2017-10-04 6:23 ` Hannes Reinecke
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-16 16:50 ` Benjamin Block
2017-10-03 10:48 ` [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues Christoph Hellwig
2017-10-04 6:26 ` Hannes Reinecke
2017-10-04 7:18 ` Johannes Thumshirn
2017-10-04 7:20 ` Christoph Hellwig
2017-10-04 8:52 ` Johannes Thumshirn
2017-10-04 7:18 ` Johannes Thumshirn
2017-10-19 15:59 ` Benjamin Block
2017-10-20 16:26 ` Christoph Hellwig
2017-10-20 16:47 ` Benjamin Block
2017-10-23 6:16 ` Martin K. Petersen
2017-10-23 6:29 ` Christoph Hellwig
2017-10-23 7:17 ` Martin K. Petersen
2017-10-24 17:46 ` Jens Axboe
2017-10-24 16:58 ` Benjamin Block
2017-10-04 14:35 ` [RFC] bsg-lib interface cleanup Jens Axboe
2017-10-17 3:50 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003104845.10417-6-hch@lst.de \
--to=hch@lst.de \
--cc=bblock@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).