* [PATCH] scsi: sd: add check for changing allow_restart
@ 2017-09-27 16:53 weiping zhang
2017-10-07 8:47 ` weiping zhang
2017-10-11 17:22 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: weiping zhang @ 2017-09-27 16:53 UTC (permalink / raw)
To: martin.petersen, jejb; +Cc: linux-scsi
/sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
writing invalid string, like following:
echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
---
drivers/scsi/sd.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3ef2214..d18639f 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -253,6 +253,7 @@ static ssize_t
allow_restart_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
+ int err, v;
struct scsi_disk *sdkp = to_scsi_disk(dev);
struct scsi_device *sdp = sdkp->device;
@@ -262,7 +263,11 @@ allow_restart_store(struct device *dev, struct device_attribute *attr,
if (sdp->type != TYPE_DISK && sdp->type != TYPE_ZBC)
return -EINVAL;
- sdp->allow_restart = simple_strtoul(buf, NULL, 10);
+ err = kstrtoint(buf, 10, &v);
+ if (err || (v != 0 && v != 1))
+ return -EINVAL;
+
+ sdp->allow_restart = v;
return count;
}
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: sd: add check for changing allow_restart
2017-09-27 16:53 [PATCH] scsi: sd: add check for changing allow_restart weiping zhang
@ 2017-10-07 8:47 ` weiping zhang
2017-10-11 17:22 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: weiping zhang @ 2017-10-07 8:47 UTC (permalink / raw)
To: martin.petersen, jejb; +Cc: linux-scsi
On Thu, Sep 28, 2017 at 12:53:18AM +0800, weiping zhang wrote:
> /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> writing invalid string, like following:
>
> echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> ---
> drivers/scsi/sd.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 3ef2214..d18639f 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -253,6 +253,7 @@ static ssize_t
> allow_restart_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> + int err, v;
> struct scsi_disk *sdkp = to_scsi_disk(dev);
> struct scsi_device *sdp = sdkp->device;
>
> @@ -262,7 +263,11 @@ allow_restart_store(struct device *dev, struct device_attribute *attr,
> if (sdp->type != TYPE_DISK && sdp->type != TYPE_ZBC)
> return -EINVAL;
>
> - sdp->allow_restart = simple_strtoul(buf, NULL, 10);
> + err = kstrtoint(buf, 10, &v);
> + if (err || (v != 0 && v != 1))
> + return -EINVAL;
> +
> + sdp->allow_restart = v;
>
> return count;
> }
> --
> 2.9.4
>
Hello Martin,
Ping
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: sd: add check for changing allow_restart
2017-09-27 16:53 [PATCH] scsi: sd: add check for changing allow_restart weiping zhang
2017-10-07 8:47 ` weiping zhang
@ 2017-10-11 17:22 ` Martin K. Petersen
2017-10-12 6:22 ` weiping zhang
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2017-10-11 17:22 UTC (permalink / raw)
To: weiping zhang; +Cc: martin.petersen, jejb, linux-scsi
weiping,
> /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> writing invalid string, like following:
>
> echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
Please switch to kstrtobool() and fix up manage_start_stop as well.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: sd: add check for changing allow_restart
2017-10-11 17:22 ` Martin K. Petersen
@ 2017-10-12 6:22 ` weiping zhang
0 siblings, 0 replies; 4+ messages in thread
From: weiping zhang @ 2017-10-12 6:22 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: jejb, linux-scsi
On Wed, Oct 11, 2017 at 01:22:18PM -0400, Martin K. Petersen wrote:
>
> weiping,
>
> > /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> > writing invalid string, like following:
> >
> > echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
>
> Please switch to kstrtobool() and fix up manage_start_stop as well.
>
> Thanks!
>
Thanks, I'll send v2 later.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-12 6:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-27 16:53 [PATCH] scsi: sd: add check for changing allow_restart weiping zhang
2017-10-07 8:47 ` weiping zhang
2017-10-11 17:22 ` Martin K. Petersen
2017-10-12 6:22 ` weiping zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).