From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH V5 4/7] blk-mq: introduce blk_mq_dequeue_from_ctx() Date: Mon, 9 Oct 2017 12:36:51 +0800 Message-ID: <20171009043650.GB19029@ming.t460p> References: <20170930102720.30219-1-ming.lei@redhat.com> <20170930102720.30219-5-ming.lei@redhat.com> <20171003090109.GB21184@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdJIEhO (ORCPT ); Mon, 9 Oct 2017 00:37:14 -0400 Content-Disposition: inline In-Reply-To: <20171003090109.GB21184@infradead.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, Mike Snitzer , dm-devel@redhat.com, Bart Van Assche , Laurence Oberman , Paolo Valente , Oleksandr Natalenko , Tom Nguyen , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Omar Sandoval On Tue, Oct 03, 2017 at 02:01:09AM -0700, Christoph Hellwig wrote: > On Sat, Sep 30, 2017 at 06:27:17PM +0800, Ming Lei wrote: > > This function is introduced for dequeuing request > > from sw queue so that we can dispatch it in > > scheduler's way. > > > > More importantly, some SCSI devices may set > > q->queue_depth, which is a per-request_queue limit, > > and applied on pending I/O from all hctxs. This > > function is introduced for avoiding to dequeue too > > many requests from sw queue when ->dispatch isn't > > flushed completely. > > Weird commit log formatting, please use your 70+ chacters to format the > text. OK. > > > @@ -882,6 +882,44 @@ void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list) > > } > > EXPORT_SYMBOL_GPL(blk_mq_flush_busy_ctxs); > > > > +struct dispatch_rq_data { > > + struct blk_mq_hw_ctx *hctx; > > + struct request *rq; > > +}; > > + > > +static bool dispatch_rq_from_ctx(struct sbitmap *sb, unsigned int bitnr, void *data) > > Overly long line. > > But except for that this looks ok to me except for the fact that you > just add an unused function. OK -- Ming