From: weiping zhang <zhangweiping@didichuxing.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: add check for changing allow_restart
Date: Thu, 12 Oct 2017 14:22:40 +0800 [thread overview]
Message-ID: <20171012062239.GA11099@source.didichuxing.com> (raw)
In-Reply-To: <yq1d15tha5x.fsf@oracle.com>
On Wed, Oct 11, 2017 at 01:22:18PM -0400, Martin K. Petersen wrote:
>
> weiping,
>
> > /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> > writing invalid string, like following:
> >
> > echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
>
> Please switch to kstrtobool() and fix up manage_start_stop as well.
>
> Thanks!
>
Thanks, I'll send v2 later.
prev parent reply other threads:[~2017-10-12 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 16:53 [PATCH] scsi: sd: add check for changing allow_restart weiping zhang
2017-10-07 8:47 ` weiping zhang
2017-10-11 17:22 ` Martin K. Petersen
2017-10-12 6:22 ` weiping zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012062239.GA11099@source.didichuxing.com \
--to=zhangweiping@didichuxing.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).