* [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()
@ 2017-10-12 20:30 Dan Carpenter
2017-10-17 2:44 ` Martin K. Petersen
2017-11-03 15:48 ` James Smart
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-10-12 20:30 UTC (permalink / raw)
To: James Smart, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
The ! has higher precedence than the & operation. I've added
parenthesis so this works as intended.
Fixes: 952c303b329c ("scsi: lpfc: Ensure io aborts interlocked with the target.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index 60f0dbd0f192..517ae570e507 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -948,7 +948,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
/* NVME targets need completion held off until the abort exchange
* completes.
*/
- if (!lpfc_ncmd->flags & LPFC_SBUF_XBUSY)
+ if (!(lpfc_ncmd->flags & LPFC_SBUF_XBUSY))
nCmd->done(nCmd);
spin_lock_irqsave(&phba->hbalock, flags);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()
2017-10-12 20:30 [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl() Dan Carpenter
@ 2017-10-17 2:44 ` Martin K. Petersen
2017-11-03 15:48 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-10-17 2:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: James Smart, Dick Kennedy, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, kernel-janitors
Dan,
> The ! has higher precedence than the & operation. I've added
> parenthesis so this works as intended.
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()
2017-10-12 20:30 [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl() Dan Carpenter
2017-10-17 2:44 ` Martin K. Petersen
@ 2017-11-03 15:48 ` James Smart
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2017-11-03 15:48 UTC (permalink / raw)
To: Dan Carpenter, Dick Kennedy
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
kernel-janitors
On 10/12/2017 1:30 PM, Dan Carpenter wrote:
> The ! has higher precedence than the & operation. I've added
> parenthesis so this works as intended.
>
> Fixes: 952c303b329c ("scsi: lpfc: Ensure io aborts interlocked with the target.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
> index 60f0dbd0f192..517ae570e507 100644
> --- a/drivers/scsi/lpfc/lpfc_nvme.c
> +++ b/drivers/scsi/lpfc/lpfc_nvme.c
> @@ -948,7 +948,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
> /* NVME targets need completion held off until the abort exchange
> * completes.
> */
> - if (!lpfc_ncmd->flags & LPFC_SBUF_XBUSY)
> + if (!(lpfc_ncmd->flags & LPFC_SBUF_XBUSY))
> nCmd->done(nCmd);
>
> spin_lock_irqsave(&phba->hbalock, flags);
yep
Signed-off-by: James Smart <james.smart@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 20:30 [PATCH] scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl() Dan Carpenter
2017-10-17 2:44 ` Martin K. Petersen
2017-11-03 15:48 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).