From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/5] qla2xxx: Add module param ql2xenablemsix
Date: Mon, 16 Oct 2017 08:57:37 +0200 [thread overview]
Message-ID: <20171016065737.rtperbhkkrkrv2lp@linux-x5ow.site> (raw)
In-Reply-To: <EE884809-2674-4801-A74A-2784467F4B09@cavium.com>
On Fri, Oct 13, 2017 at 06:52:31PM +0000, Madhani, Himanshu wrote:
> Sorry this one slipped out of my sight. The reason I used "ql2xenablemsix" was because driver already
> had this parameter in code until few versions back where we removed it. Since existing user are familiar
> with this module parameter name, it would be easy to keep that same.
>
> Let me know if you are okay with the name or prefer new name instead?
Heh I knew I had seen this parameter before, just couldn't find it anymore and
thought I must have been dreaming.
If it's only for reconstructing a previous stsate, it wouldn't make much sense
to rename it then.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-10-16 6:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 20:36 [PATCH 0/5] qla2xxx: Patches for scsi-misc Madhani, Himanshu
2017-10-11 20:36 ` [PATCH 1/5] qla2xxx: Add module param ql2xenablemsix Madhani, Himanshu
2017-10-12 7:19 ` Johannes Thumshirn
2017-10-13 18:52 ` Madhani, Himanshu
2017-10-16 6:57 ` Johannes Thumshirn [this message]
2017-10-11 20:36 ` [PATCH 2/5] qla2xxx: Add ATIO-Q processing for INTx mode Madhani, Himanshu
2017-10-12 7:25 ` Johannes Thumshirn
2017-10-11 20:36 ` [PATCH 3/5] qla2xxx: Allow MBC_GET_PORT_DATABASE to query and save the port states Madhani, Himanshu
2017-10-12 7:26 ` Johannes Thumshirn
2017-10-11 20:36 ` [PATCH 4/5] qla2xxx: Changes to support N2N logins Madhani, Himanshu
2017-10-12 7:29 ` Johannes Thumshirn
2017-10-13 5:46 ` kbuild test robot
2017-10-13 5:47 ` kbuild test robot
2017-10-11 20:36 ` [PATCH 5/5] qla2xxx: Update driver version to 10.00.00.02-k Madhani, Himanshu
2017-10-12 7:29 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016065737.rtperbhkkrkrv2lp@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=Himanshu.Madhani@cavium.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).