From: Viswas G <Viswas.G@microsemi.com>
To: linux-scsi@vger.kernel.org
Cc: Vasanthalakshmi.Tharmarajan@microsemi.com,
Viswas.G@microsemi.com, deepak.ukey@microsemi.com,
Raj.Dinesh@microsemi.com, jinpu.wang@profitbricks.com,
martin.petersen@oracle.com
Subject: [PATCH V4 8/9] pm80xx : panic on ncq error cleaning up the read log.
Date: Wed, 18 Oct 2017 11:39:14 +0530 [thread overview]
Message-ID: <20171018060915.8549-9-Viswas.G@microsemi.com> (raw)
In-Reply-To: <20171018060915.8549-1-Viswas.G@microsemi.com>
when there's an error in 'ncq mode' the host has to read the ncq
error log (10h) to clear the error state. however, the ccb that
is setup for doing this doesn't setup the ccb so that the
previous state is cleared. if the ccb was previously used for an IO
n_elems is set and pm8001_ccb_task_free() treats this as the signal
to go free a scatter-gather list (that's already been free-ed).
Signed-off-by: Deepak Ukey <deepak.ukey@microsemi.com>
Signed-off-by: Viswas G <Viswas.G@microsemi.com>
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
---
drivers/scsi/pm8001/pm80xx_hwi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
index f6df11a7c2d5..42f0405601ad 100644
--- a/drivers/scsi/pm8001/pm80xx_hwi.c
+++ b/drivers/scsi/pm8001/pm80xx_hwi.c
@@ -1489,6 +1489,7 @@ static void pm80xx_send_read_log(struct pm8001_hba_info *pm8001_ha,
ccb->device = pm8001_ha_dev;
ccb->ccb_tag = ccb_tag;
ccb->task = task;
+ ccb->n_elem = 0;
pm8001_ha_dev->id |= NCQ_READ_LOG_FLAG;
pm8001_ha_dev->id |= NCQ_2ND_RLE_FLAG;
--
2.12.3
next prev parent reply other threads:[~2017-10-18 6:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 6:09 [PATCH V4 0/9] pm80xx updates Viswas G
2017-10-18 6:09 ` [PATCH V4 1/9] pm80xx : redefine sas_identify_frame structure Viswas G
2017-10-18 6:09 ` [PATCH V4 2/9] pm80xx : ILA and inactive firmware version through sysfs Viswas G
2017-10-18 6:09 ` [PATCH V4 3/9] pm80xx : Different SAS addresses for phys Viswas G
2017-10-18 6:09 ` [PATCH V4 4/9] pm80xx : tag allocation for phy control request Viswas G
2017-10-18 6:09 ` [PATCH V4 5/9] pm80xx : cleanup in pm8001_abort_task function Viswas G
2017-10-18 6:09 ` [PATCH V4 6/9] pm80xx : modified port reset timer value for PM8006 card Viswas G
2017-10-18 6:09 ` [PATCH V4 7/9] pm80xx : corrected SATA abort handling sequence Viswas G
2017-10-18 6:09 ` Viswas G [this message]
2017-10-18 6:09 ` [PATCH V4 9/9] pm80xx : corrected linkrate value Viswas G
2017-10-18 8:10 ` [PATCH V4 0/9] pm80xx updates Jinpu Wang
2017-10-19 2:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018060915.8549-9-Viswas.G@microsemi.com \
--to=viswas.g@microsemi.com \
--cc=Raj.Dinesh@microsemi.com \
--cc=Vasanthalakshmi.Tharmarajan@microsemi.com \
--cc=deepak.ukey@microsemi.com \
--cc=jinpu.wang@profitbricks.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).