From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] blk-mq: Revert multiple recent patches
Date: Tue, 7 Nov 2017 10:29:39 +0800 [thread overview]
Message-ID: <20171107022938.GE15090@ming.t460p> (raw)
In-Reply-To: <20171107010731.5099-1-bart.vanassche@wdc.com>
On Mon, Nov 06, 2017 at 05:07:31PM -0800, Bart Van Assche wrote:
> Since we are close to the merge window and since it is too late for
> reworking patches and algorithms that have turned out to be flawed,
> revert multiple recent patches. Revert patch "blk-mq: don't handle
> TAG_SHARED in restart" and all patches that conflict with the revert
> of that patch because that patch is based on an incorrect assumption,
> namely that the SCSI starved list can be used as a replacement for
> the blk-mq queue restarting mechanism. Revert patch "scsi: implement
> .get_budget and .put_budget for blk-mq" because it triggers an
> infinite loop on my test setup ("scsi 9:0:0:0: rejecting I/O to dead
> device" + RCU lockup complaint in blk_mq_sched_dispatch_requests()).
The loop can be fixed by
88022d7201e9 blk-mq: don't handle failure in .get_budget
--
Ming
next prev parent reply other threads:[~2017-11-07 2:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 1:07 [PATCH] blk-mq: Revert multiple recent patches Bart Van Assche
2017-11-07 2:29 ` Ming Lei [this message]
2017-11-07 2:41 ` Ming Lei
2017-11-07 2:56 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107022938.GE15090@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox