From: Bart Van Assche <bart.vanassche@wdc.com>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bart.vanassche@wdc.com>
Subject: [PATCH 0/3] Improve device information handling
Date: Tue, 14 Nov 2017 16:57:18 -0800 [thread overview]
Message-ID: <20171115005721.11023-1-bart.vanassche@wdc.com> (raw)
Hello Martin,
There are multiple issues with the device information flag handling (a.k.a.
blacklist flags):
* For neither scsi_get_device_flags() nor scsi_get_device_flags_keyed() it
is possible to determine whether an error code has been returned or whether
the flag with bit position 31 was set.
* A large number of sparse warnings is generated by the blacklist flags code.
The three patches in this series address these issues.
Please consider these patches for inclusion in the upstream kernel.
Thanks,
Bart.
Bart Van Assche (3):
device information: Do not interpret error codes as flags
Constify scsi_dev_info_list_add_keyed() string arguments
Introduce a type for device information flags, namely bflags_t
drivers/scsi/scsi_devinfo.c | 48 +++++++++++++++++++-----------------
drivers/scsi/scsi_priv.h | 12 +++++----
drivers/scsi/scsi_scan.c | 28 +++++++++++----------
drivers/scsi/scsi_sysfs.c | 4 +--
drivers/scsi/scsi_transport_spi.c | 11 +++++----
include/scsi/scsi_device.h | 3 ++-
include/scsi/scsi_devinfo.h | 52 ++++++++++++++++++++-------------------
include/scsi/scsi_types.h | 6 +++++
8 files changed, 90 insertions(+), 74 deletions(-)
create mode 100644 include/scsi/scsi_types.h
--
2.15.0
next reply other threads:[~2017-11-15 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 0:57 Bart Van Assche [this message]
2017-11-15 0:57 ` [PATCH 1/3] device information: Do not interpret error codes as flags Bart Van Assche
2017-11-15 0:57 ` [PATCH 2/3] Constify scsi_dev_info_list_add_keyed() string arguments Bart Van Assche
2017-11-15 0:57 ` [PATCH 3/3] Introduce a type for device information flags, namely bflags_t Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-11-15 2:33 [PATCH 0/3] Improve device information handling Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115005721.11023-1-bart.vanassche@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox