From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: [PATCH v3 01/17] lpfc: FLOGI failures are reported when connected to a private loop.
Date: Mon, 20 Nov 2017 16:00:28 -0800 [thread overview]
Message-ID: <20171121000044.27702-2-jsmart2021@gmail.com> (raw)
In-Reply-To: <20171121000044.27702-1-jsmart2021@gmail.com>
When the HBA is connected to a private loop, the driver
reports FLOGI loop-open failure as functional error. This is
an expected condition.
Mark loop-open failure as a warning instead of error.
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
drivers/scsi/lpfc/lpfc_els.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index b14f7c5653cd..c81cdc637e64 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -1030,30 +1030,31 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
stop_rr_fcf_flogi:
/* FLOGI failure */
- lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
- "2858 FLOGI failure Status:x%x/x%x TMO:x%x "
- "Data x%x x%x\n",
- irsp->ulpStatus, irsp->un.ulpWord[4],
- irsp->ulpTimeout, phba->hba_flag,
- phba->fcf.fcf_flag);
+ if (!(irsp->ulpStatus == IOSTAT_LOCAL_REJECT &&
+ ((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==
+ IOERR_LOOP_OPEN_FAILURE)))
+ lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
+ "2858 FLOGI failure Status:x%x/x%x "
+ "TMO:x%x Data x%x x%x\n",
+ irsp->ulpStatus, irsp->un.ulpWord[4],
+ irsp->ulpTimeout, phba->hba_flag,
+ phba->fcf.fcf_flag);
/* Check for retry */
if (lpfc_els_retry(phba, cmdiocb, rspiocb))
goto out;
- /* FLOGI failure */
- lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
- "0100 FLOGI failure Status:x%x/x%x TMO:x%x\n",
- irsp->ulpStatus, irsp->un.ulpWord[4],
- irsp->ulpTimeout);
-
-
/* If this is not a loop open failure, bail out */
if (!(irsp->ulpStatus == IOSTAT_LOCAL_REJECT &&
((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==
IOERR_LOOP_OPEN_FAILURE)))
goto flogifail;
+ lpfc_printf_vlog(vport, KERN_WARNING, LOG_ELS,
+ "0150 FLOGI failure Status:x%x/x%x TMO:x%x\n",
+ irsp->ulpStatus, irsp->un.ulpWord[4],
+ irsp->ulpTimeout);
+
/* FLOGI failed, so there is no fabric */
spin_lock_irq(shost->host_lock);
vport->fc_flag &= ~(FC_FABRIC | FC_PUBLIC_LOOP);
--
2.13.1
next prev parent reply other threads:[~2017-11-21 0:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 0:00 [PATCH v3 00/17] lpfc updates for 11.4.0.5 James Smart
2017-11-21 0:00 ` James Smart [this message]
2017-11-21 0:00 ` [PATCH v3 02/17] lpfc: Expand WQE capability of every NVME hardware queue James Smart
2017-11-21 0:00 ` [PATCH v3 03/17] lpfc: Handle XRI_ABORTED_CQE in soft IRQ James Smart
2017-11-21 0:00 ` [PATCH v3 04/17] lpfc: Fix crash after bad bar setup on driver attachment James Smart
2017-11-21 0:00 ` [PATCH v3 05/17] lpfc: Fix NVME LS abort_xri James Smart
2017-11-21 0:00 ` [PATCH v3 06/17] lpfc: Raise maximum NVME sg list size for 256 elements James Smart
2017-11-21 0:00 ` [PATCH v3 07/17] lpfc: Driver fails to detect direct attach storage array James Smart
2017-11-21 0:00 ` [PATCH v3 08/17] lpfc: Fix display for debugfs queInfo James Smart
2017-11-21 0:00 ` [PATCH v3 09/17] lpfc: Adjust default value of lpfc_nvmet_mrq James Smart
2017-11-21 0:00 ` [PATCH v3 10/17] lpfc: Fix ndlp ref count for pt2pt mode issue RSCN James Smart
2017-11-21 0:00 ` [PATCH v3 11/17] lpfc: Linux LPFC driver does not process all RSCNs James Smart
2017-11-21 8:12 ` Hannes Reinecke
2017-11-21 0:00 ` [PATCH v3 12/17] lpfc: correct port registrations with nvme_fc James Smart
2017-11-21 0:00 ` [PATCH v3 13/17] lpfc: Correct driver deregistrations with host nvme transport James Smart
2017-11-21 8:13 ` Hannes Reinecke
2017-11-21 0:00 ` [PATCH v3 14/17] lpfc: Fix crash during driver unload with running nvme traffic James Smart
2017-11-21 0:00 ` [PATCH v3 15/17] lpfc: Fix driver handling of nvme resources during unload James Smart
2017-11-21 0:00 ` [PATCH v3 16/17] lpfc: small sg cnt cleanup James Smart
2017-11-21 0:00 ` [PATCH v3 17/17] lpfc: update driver version to 11.4.0.5 James Smart
2017-11-22 3:56 ` [PATCH v3 00/17] lpfc updates for 11.4.0.5 Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121000044.27702-2-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).