From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH v2] Use blist_flags_t consistently
Date: Tue, 12 Dec 2017 08:52:08 +0100 [thread overview]
Message-ID: <20171212075208.GA32670@lst.de> (raw)
In-Reply-To: <20171212000803.5989-1-bart.vanassche@wdc.com>
On Mon, Dec 11, 2017 at 04:08:03PM -0800, Bart Van Assche wrote:
> + if (!((__force unsigned int)sdev->sdev_bflags & BIT(i)))
I'd case the right side argument to __force blist_flags_t here for
purely esthetic reasons.
Except for that this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-12-12 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 0:08 [PATCH v2] Use blist_flags_t consistently Bart Van Assche
2017-12-12 7:52 ` Christoph Hellwig [this message]
2017-12-12 16:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212075208.GA32670@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).