From: Omar Sandoval <osandov@osandov.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Omar Sandoval <osandov@fb.com>,
linux-scsi@vger.kernel.org, Johannes Thumshirn <jth@kernel.org>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/2] tests/scsi/0001: Regression test for SCSI device blacklisting
Date: Wed, 13 Dec 2017 01:29:39 -0800 [thread overview]
Message-ID: <20171213092939.GA2842@vader> (raw)
In-Reply-To: <20170816060049.GA6640@vader>
On Tue, Aug 15, 2017 at 11:00:49PM -0700, Omar Sandoval wrote:
> On Wed, Aug 09, 2017 at 12:50:06PM +0200, Hannes Reinecke wrote:
> > SCSI device blacklisting seems to be a tricky subject, with
> > lots of potential for messing up the selection algorithm.
> > This adds a test for catching regressions here.
>
> I'm waiting to see how the patches end up before applying this, but I'm
> glad to see this test :) A few comments below. I've addressed most of
> them and pushed it to https://github.com/osandov/blktests/tree/scsi-blacklist,
> but the golden output needs to be updated for v3 of your patches. Could
> you modify the patch in my branch and resend? Thanks for adding tests!
Hannes, can you resend these tests now that your patches are in? Let me
know if you need any help. Thanks!
next prev parent reply other threads:[~2017-12-13 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 10:50 [PATCH 1/2] tests/scsi: add SCSI midlayer test group Hannes Reinecke
2017-08-09 10:50 ` [PATCH 2/2] tests/scsi/0001: Regression test for SCSI device blacklisting Hannes Reinecke
2017-08-15 23:13 ` Bart Van Assche
2017-08-16 6:00 ` Omar Sandoval
2017-12-13 9:29 ` Omar Sandoval [this message]
2017-08-16 1:14 ` [PATCH 1/2] tests/scsi: add SCSI midlayer test group Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213092939.GA2842@vader \
--to=osandov@osandov.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jth@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).