From: Christoph Hellwig <hch@lst.de>
To: Jason Yan <yanaijie@huawei.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org, zhaohongjiang@huawei.com,
miaoxie@huawei.com, hch@lst.de, hare@suse.com,
chenxiang <chenxiang66@hisilicon.com>
Subject: Re: [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER
Date: Thu, 4 Jan 2018 13:41:21 +0100 [thread overview]
Message-ID: <20180104124121.GC6749@lst.de> (raw)
In-Reply-To: <20180104114741.37358-4-yanaijie@huawei.com>
On Thu, Jan 04, 2018 at 07:47:41PM +0800, Jason Yan wrote:
> + phy->phy->enabled = (phy->linkrate == SAS_PHY_DISABLED) ? 0:1;
missing whitespaces around the ":, but this could just be simplified to:
phy->phy->enabled = (phy->linkrate != SAS_PHY_DISABLED);
Otherwise this looks fine.
next prev parent reply other threads:[~2018-01-04 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 11:47 [PATCH v2 0/3] Three small fixes for libsas Jason Yan
2018-01-04 11:47 ` [PATCH v2 1/3] scsi: libsas: fix memory leak in sas_smp_get_phy_events() Jason Yan
2018-01-04 12:38 ` Christoph Hellwig
2018-01-04 11:47 ` [PATCH v2 2/3] scsi: libsas: fix error when getting phy events Jason Yan
2018-01-04 12:39 ` Christoph Hellwig
2018-01-04 11:47 ` [PATCH v2 3/3] scsi: libsas: initialize sas_phy status according to response of DISCOVER Jason Yan
2018-01-04 12:41 ` Christoph Hellwig [this message]
2018-01-04 12:42 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180104124121.GC6749@lst.de \
--to=hch@lst.de \
--cc=chenxiang66@hisilicon.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).