* [PATCH] tcmu: Fix trailing semicolon
@ 2018-01-16 15:34 Luis de Bethencourt
2018-01-16 16:25 ` Michael Christie
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-16 15:34 UTC (permalink / raw)
To: linux-kernel
Cc: Joe Perches, Nicholas A . Bellinger, linux-scsi, target-devel,
Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
drivers/target/target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 60c8a87b7a88..f6164d294fb3 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev)
wake_up_all(&udev->nl_cmd_wq);
- return ret;;
+ return ret;
}
static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcmu: Fix trailing semicolon
2018-01-16 15:34 [PATCH] tcmu: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-16 16:25 ` Michael Christie
2018-01-18 9:23 ` Nicholas A. Bellinger
0 siblings, 1 reply; 3+ messages in thread
From: Michael Christie @ 2018-01-16 16:25 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Joe Perches, Nicholas A . Bellinger, linux-scsi, target-devel
On 01/16/2018 09:34 AM, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> It is completely stripped out by the compiler. Removing it since it doesn't do
> anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> drivers/target/target_core_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 60c8a87b7a88..f6164d294fb3 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev)
>
> wake_up_all(&udev->nl_cmd_wq);
>
> - return ret;;
> + return ret;
> }
>
> static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,
>
Acked-by: Mike Christie <mchristi@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcmu: Fix trailing semicolon
2018-01-16 16:25 ` Michael Christie
@ 2018-01-18 9:23 ` Nicholas A. Bellinger
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas A. Bellinger @ 2018-01-18 9:23 UTC (permalink / raw)
To: mchristi
Cc: Luis de Bethencourt, linux-kernel, Joe Perches, linux-scsi,
target-devel
On Tue, 2018-01-16 at 10:25 -0600, Michael Christie wrote:
> On 01/16/2018 09:34 AM, Luis de Bethencourt wrote:
> > The trailing semicolon is an empty statement that does no operation.
> > It is completely stripped out by the compiler. Removing it since it doesn't do
> > anything.
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> > ---
> >
> > Hi,
> >
> > After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> > suggested I fix it treewide [0].
> >
> > Best regards
> > Luis
> >
> >
> > [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> > [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> >
> > drivers/target/target_core_user.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
Applied. Thanks Luis + MNC.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-18 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 15:34 [PATCH] tcmu: Fix trailing semicolon Luis de Bethencourt
2018-01-16 16:25 ` Michael Christie
2018-01-18 9:23 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox