From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] scsi_debug: Use scsi-mq if it has been enabled
Date: Fri, 26 Jan 2018 08:58:37 +0100 [thread overview]
Message-ID: <20180126075837.GF2356@lst.de> (raw)
In-Reply-To: <20180124003958.3945-1-bart.vanassche@wdc.com>
On Tue, Jan 23, 2018 at 04:39:58PM -0800, Bart Van Assche wrote:
> Since we want to remove the single queue code from the SCSI core
> at the appropriate time and since scsi-mq performs better than
> scsi-sq even when using only a single hardware queue, use scsi-mq
> if it has been enabled.
scsi_debug already always uses scsi-mq if enabled. The somewhat
misnamed sdebug_mq_active variable is only used for decoding
multiqueue tags. That being said the blk_mq_unique_tag* helpers
should be safe to use even without blk-mq, so the variable could
probably just be removed entirely.
next prev parent reply other threads:[~2018-01-26 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 0:39 [PATCH] scsi_debug: Use scsi-mq if it has been enabled Bart Van Assche
2018-01-24 6:29 ` Douglas Gilbert
2018-01-26 7:58 ` Christoph Hellwig [this message]
2018-01-26 16:10 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126075837.GF2356@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@wdc.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox