From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
Stanislav Nijnikov <Stanislav.Nijnikov@wdc.com>,
Alex Lemberg <Alex.Lemberg@wdc.com>
Subject: Re: [PATCH v4 02/10] ufs: sysfs: device descriptor
Date: Fri, 2 Feb 2018 08:17:35 +0100 [thread overview]
Message-ID: <20180202071735.GC9314@kroah.com> (raw)
In-Reply-To: <1517531145.2746.26.camel@wdc.com>
On Fri, Feb 02, 2018 at 12:25:46AM +0000, Bart Van Assche wrote:
> On Thu, 2018-02-01 at 18:15 +0200, Stanislav Nijnikov wrote:
> > +enum ufs_desc_param_size {
> > + UFS_PARAM_BYTE_SIZE = 1,
> > + UFS_PARAM_WORD_SIZE = 2,
> > + UFS_PARAM_DWORD_SIZE = 4,
> > + UFS_PARAM_QWORD_SIZE = 8,
> > +};
>
> Please do not copy bad naming choices from the Windows kernel into the Linux
> kernel. Using names like WORD / DWORD / QWORD is much less readable than using
> the numeric constants 2, 4, 8. Hence my proposal to leave out the above enum
> completely.
Are you sure those do not come from the spec itself? It's been a while
since I last read it, but for some reason I remember those types of
names being in there. But I might be confusing specs here.
thanks,
greg k-h
next prev parent reply other threads:[~2018-02-02 7:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 16:15 [PATCH v4 00/10] ufs: sysfs: read-only access to device descriptors, attributes and flags Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 01/10] ufs: sysfs: attribute group for existing sysfs entries Stanislav Nijnikov
2018-02-01 16:59 ` Greg KH
2018-02-04 12:29 ` Stanislav Nijnikov
2018-02-04 12:33 ` Greg KH
2018-02-04 13:09 ` Stanislav Nijnikov
2018-02-04 13:15 ` Greg KH
2018-02-01 16:15 ` [PATCH v4 02/10] ufs: sysfs: device descriptor Stanislav Nijnikov
2018-02-01 17:00 ` Greg KH
2018-02-02 0:25 ` Bart Van Assche
2018-02-02 7:17 ` gregkh [this message]
2018-02-02 16:32 ` Bart Van Assche
2018-02-04 9:03 ` Stanislav Nijnikov
2018-02-04 10:44 ` gregkh
2018-02-02 0:29 ` Bart Van Assche
2018-02-01 16:15 ` [PATCH v4 03/10] ufs: sysfs: interconnect descriptor Stanislav Nijnikov
2018-02-01 17:01 ` Greg KH
2018-02-01 16:15 ` [PATCH v4 04/10] ufs: sysfs: geometry descriptor Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 05/10] ufs: sysfs: health descriptor Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 06/10] ufs: sysfs: power descriptor Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 07/10] ufs: sysfs: string descriptors Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 08/10] ufs: sysfs: unit descriptor Stanislav Nijnikov
2018-02-02 0:38 ` Bart Van Assche
2018-02-01 16:15 ` [PATCH v4 09/10] ufs: sysfs: flags Stanislav Nijnikov
2018-02-01 16:15 ` [PATCH v4 10/10] ufs: sysfs: attributes Stanislav Nijnikov
2018-02-01 17:03 ` Greg KH
2018-02-01 16:48 ` [PATCH v4 00/10] ufs: sysfs: read-only access to device descriptors, attributes and flags Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202071735.GC9314@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alex.Lemberg@wdc.com \
--cc=Bart.VanAssche@wdc.com \
--cc=Stanislav.Nijnikov@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox