From: Tejun Heo <tj@kernel.org>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
Martin Steigerwald <martin@lichtvoll.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched()
Date: Mon, 19 Mar 2018 07:31:47 -0700 [thread overview]
Message-ID: <20180319143147.GF2943022@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180316173516.3048-1-bart.vanassche@wdc.com>
On Fri, Mar 16, 2018 at 10:35:16AM -0700, Bart Van Assche wrote:
> Since blk_queue_enter() uses rcu_read_lock_sched() scsi_device_quiesce()
> must use synchronize_sched().
Is there a reason to use sched-RCU here instead of the regular one?
If not, it'd be better to switch to regular RCU than the other way
around.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-03-19 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 17:35 [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched() Bart Van Assche
2018-03-16 21:42 ` Martin Steigerwald
2018-03-16 21:51 ` Bart Van Assche
2018-03-19 9:02 ` Martin Steigerwald
2018-03-19 14:31 ` Tejun Heo [this message]
2018-03-19 15:16 ` Bart Van Assche
2018-03-19 15:21 ` tj
2018-03-19 16:18 ` Bart Van Assche
2018-03-19 16:29 ` tj
2018-03-19 16:57 ` Bart Van Assche
2018-03-19 17:02 ` tj
2018-03-19 20:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319143147.GF2943022@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=martin@lichtvoll.de \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox