Re: [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched()

Bart Van Assche
2018-03-16T21:51:43Z

On 03/16/18 14:42, Martin Steigerwald wrote:
> What is this one about?
>
> Fix for the regression I (and others?) reported?¹
>
> [1] [Bug 199077] [Possible REGRESSION, 4.16-rc4] Error updating SMART data
> during runtime and boot failures with blk_mq_terminate_expired in backtrace
>
> https://bugzilla.kernel.org/show_bug.cgi?id=199077

Hello Martin,

This patch is a fix for the fix for the bug that you and others had
reported. See also "I/O hangs after resuming from suspend-to-ram"
(https://marc.info/?l=linux-block&m=150340235201348).

This patch fixes an API violation. For those users for which suspend and
resume works fine with commit 3a0a529971ec applied it should still work
fine with this patch applied since this patch may cause
scsi_device_quiesce() to wait longer.

Bart.