Re: [PATCH v2 2/3] scsi: check for equality of result byte values

Bart Van Assche
2018-06-13T13:09:06Z

On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote:
> if ((cmd->result == (DID_OK << 16)
> - || status_byte(cmd->result) &
> - CHECK_CONDITION)) {
> + || status_byte(cmd->result) == CHECK_CONDITION)) {

A minor comment: the preferred coding style is to place "||" at the end of the
previous line.

> - if ((driver_byte(the_result) & DRIVER_SENSE) == 0) {
> + if (driver_byte(the_result) == DRIVER_SENSE) {

This change looks wrong to me.

Bart.