From: Rob Herring <robh@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Sayali Lokhande <sayalil@codeaurora.org>,
subhashj@codeaurora.org, cang@codeaurora.org,
vivek.gautam@codeaurora.org, rnayak@codeaurora.org,
vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, asutoshd@codeaurora.org,
evgreen@chromium.org, riteshh@codeaurora.org,
linux-scsi@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
Mathieu Malaterre <malat@debian.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/3] scsi: ufs: set the device reference clock setting
Date: Wed, 20 Jun 2018 12:01:54 -0600 [thread overview]
Message-ID: <20180620180154.GA18559@rob-hp-laptop> (raw)
In-Reply-To: <bf87ec58-69c0-fe59-cfa1-8dc7dc80ca46@intel.com>
On Wed, Jun 20, 2018 at 10:26:07AM +0300, Adrian Hunter wrote:
> On 14/06/18 16:03, Sayali Lokhande wrote:
> > From: Subhash Jadavani <subhashj@codeaurora.org>
> >
> > UFS host supplies the reference clock to UFS device and UFS device
> > specification allows host to provide one of the 4 frequencies (19.2 MHz,
> > 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the
> > device reference clock frequency setting in the device based on what
> > frequency it is supplying to UFS device.
> >
> > Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
> > Signed-off-by: Can Guo <cang@codeaurora.org>
> > Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
>
> I have repeated my V2 comments below. Please address these when you post
> V4. Also please provide a change log for each patch version.
Do I have to repeat my V2 comments too? Please don't send a V4 until the
discussion on V2 is resolved.
Rob
next prev parent reply other threads:[~2018-06-20 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1528981432-23065-1-git-send-email-sayalil@codeaurora.org>
2018-06-14 13:03 ` [PATCH V3 1/3] scsi: ufs: set the device reference clock setting Sayali Lokhande
2018-06-20 7:26 ` Adrian Hunter
2018-06-20 18:01 ` Rob Herring [this message]
2018-06-21 9:11 ` sayali
2018-06-21 9:19 ` Adrian Hunter
2018-06-14 13:03 ` [PATCH V3 2/3] scsi: ufs: Add ufs provisioning support Sayali Lokhande
2018-06-14 15:39 ` Christoph Hellwig
2018-06-15 2:58 ` Kyuho Choi
2018-06-21 9:17 ` sayali
2018-06-14 13:03 ` [PATCH V3 3/3] scsi: ufs: Add configfs support for ufs provisioning Sayali Lokhande
2018-06-14 15:29 ` kbuild test robot
2018-06-14 17:53 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620180154.GA18559@rob-hp-laptop \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=riteshh@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).