From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: [PATCH] sbitmap, scsi/target: add seq_file forward declaration Date: Fri, 6 Jul 2018 15:23:43 +0200 Message-ID: <20180706132407.4069001-1-arnd@arndb.de> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: "Martin K . Petersen" Cc: Jens Axboe , Felipe Balbi , Matthew Wilcox , linux-scsi@vger.kernel.org, "James E . J . Bottomley" , Arnd Bergmann , Omar Sandoval , Ming Lei , Paolo Valente , linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org The target core runs into a warning in the linux/sbitmap.h file in some configurations: In file included from include/target/target_core_base.h:7, from drivers/target/target_core_fabric_lib.c:41: include/linux/sbitmap.h:331:46: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void sbitmap_show(struct sbitmap *sb, struct seq_file *m); ^~~~~~~~ In general, headers should not depend on others being included first, so this fixes it with a forward declaration for that struct name, but we probably want to merge the patch through the scsi tree to help bisection. Fixes: 10e9cbb6b531 ("scsi: target: Convert target drivers to use sbitmap") Signed-off-by: Arnd Bergmann --- include/linux/sbitmap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/sbitmap.h b/include/linux/sbitmap.h index e6539536dea9..cc54b9f7ff8b 100644 --- a/include/linux/sbitmap.h +++ b/include/linux/sbitmap.h @@ -321,6 +321,8 @@ static inline int sbitmap_test_bit(struct sbitmap *sb, unsigned int bitnr) unsigned int sbitmap_weight(const struct sbitmap *sb); +struct seq_file; + /** * sbitmap_show() - Dump &struct sbitmap information to a &struct seq_file. * @sb: Bitmap to show. -- 2.9.0