* [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit()
@ 2018-08-01 23:31 Matthias Kaehlcke
2018-08-07 17:22 ` Evan Green
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2018-08-01 23:31 UTC (permalink / raw)
To: Vinayak Holikatti, James E . J . Bottomley, Martin K . Petersen,
Subhash Jadavani
Cc: linux-scsi, linux-kernel, Evan Green, Douglas Anderson,
Stephen Boyd, Matthias Kaehlcke
Commit 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during
clock gating") introduced a check in ufshcd_hba_exit() to suspend
clock scaling only when the controller supports clock scaling.
However the unconditional call to ufshcd_suspend_clkscaling() was
also left in place, so that it is now called twice when clock
scaling is supported and still once when the controller doesn't
support it. Remove the unconditional call.
Fixes: 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during clock gating")
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 397081d320b1..dca7525af696 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -7186,7 +7186,6 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
if (hba->is_powered) {
ufshcd_variant_hba_exit(hba);
ufshcd_setup_vreg(hba, false);
- ufshcd_suspend_clkscaling(hba);
if (ufshcd_is_clkscaling_supported(hba)) {
if (hba->devfreq)
ufshcd_suspend_clkscaling(hba);
--
2.18.0.597.ga71716f1ad-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit()
2018-08-01 23:31 [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit() Matthias Kaehlcke
@ 2018-08-07 17:22 ` Evan Green
0 siblings, 0 replies; 2+ messages in thread
From: Evan Green @ 2018-08-07 17:22 UTC (permalink / raw)
To: mka
Cc: Vinayak Holikatti, jejb, martin.petersen, subhashj, linux-scsi,
linux-kernel, Doug Anderson, sboyd
On Wed, Aug 1, 2018 at 4:31 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Commit 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during
> clock gating") introduced a check in ufshcd_hba_exit() to suspend
> clock scaling only when the controller supports clock scaling.
> However the unconditional call to ufshcd_suspend_clkscaling() was
> also left in place, so that it is now called twice when clock
> scaling is supported and still once when the controller doesn't
> support it. Remove the unconditional call.
>
> Fixes: 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during clock gating")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 397081d320b1..dca7525af696 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7186,7 +7186,6 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
> if (hba->is_powered) {
> ufshcd_variant_hba_exit(hba);
> ufshcd_setup_vreg(hba, false);
> - ufshcd_suspend_clkscaling(hba);
> if (ufshcd_is_clkscaling_supported(hba)) {
> if (hba->devfreq)
> ufshcd_suspend_clkscaling(hba);
> --
> 2.18.0.597.ga71716f1ad-goog
>
Reviewed-by: Evan Green <evgreen@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-07 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 23:31 [PATCH] scsi: ufs: Suspend clock scaling only once in ufshcd_hba_exit() Matthias Kaehlcke
2018-08-07 17:22 ` Evan Green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).